You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "dpogue (via GitHub)" <gi...@apache.org> on 2024/03/20 07:05:20 UTC
[PR] chore(ci): Fix ObjC testing with latest Xcode [cordova-ios]
dpogue opened a new pull request, #1412:
URL: https://github.com/apache/cordova-ios/pull/1412
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Tests would fail to run in Xcode 15 due to not having a iPhone 8 simulator with the latest runtime, and `CONFIGURATION_BUILD_DIR` was causing errors about Cordova.framework not being found and sometimes warnings about stale files.
### Description
<!-- Describe your changes in detail -->
* Move macOS CI to run on macOS 14 on Apple Silicon, using Xcode 15
* Set the tests to run with an iPhone 15 simulator
* Fix a warning about a missing cast to `AppDelegate*`
* Set `-derivedDataPath` rather than `CONFIGURATION_BUILD_DIR` so that Apple doesn't cache stale data about previous runs
### Testing
<!-- Please describe in detail how you tested your changes. -->
Ran in GitHub CI and locally with latest Xcode 15
### Checklist
- [x] I've run the tests to see all new and existing tests pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore(ci): Fix ObjC testing with latest Xcode [cordova-ios]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1412:
URL: https://github.com/apache/cordova-ios/pull/1412#issuecomment-2008922554
## [Codecov](https://app.codecov.io/gh/apache/cordova-ios/pull/1412?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 78.50%. Comparing base [(`c97845a`)](https://app.codecov.io/gh/apache/cordova-ios/commit/c97845acb7e4fe659c0f71103bef44700da37d5c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`50fdd29`)](https://app.codecov.io/gh/apache/cordova-ios/pull/1412?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #1412 +/- ##
=======================================
Coverage 78.50% 78.50%
=======================================
Files 16 16
Lines 1814 1814
=======================================
Hits 1424 1424
Misses 390 390
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cordova-ios/pull/1412?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore(ci): Fix ObjC testing with latest Xcode [cordova-ios]
Posted by "erisu (via GitHub)" <gi...@apache.org>.
erisu merged PR #1412:
URL: https://github.com/apache/cordova-ios/pull/1412
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org