You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2017/03/02 06:30:15 UTC
[kudu-CR] KUDU-1834 Don't redact KuduRowResult::ToString()
Andrew Wong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6222
Change subject: KUDU-1834 Don't redact KuduRowResult::ToString()
......................................................................
KUDU-1834 Don't redact KuduRowResult::ToString()
A user on the client side calling ToString on the results of a scan
will likely expect the data to not be redacted. This patch forces
KuduScanPatch::RowPtr::ToString() to not redact.
A test case is added to client-test that turns redaction on and
compares the output of ToString with a redacted row. If the row is
redacted, this case fill fail.
Change-Id: If966e9ba76f747de85350ffa2b91fcf05a9ad324
---
M src/kudu/client/client-test.cc
M src/kudu/client/scan_batch.cc
2 files changed, 34 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/6222/1
--
To view, visit http://gerrit.cloudera.org:8080/6222
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If966e9ba76f747de85350ffa2b91fcf05a9ad324
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] KUDU-1834 Don't redact KuduRowResult::ToString()
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: KUDU-1834 Don't redact KuduRowResult::ToString()
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6222
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If966e9ba76f747de85350ffa2b91fcf05a9ad324
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] KUDU-1834 Don't redact KuduRowResult::ToString()
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change.
Change subject: KUDU-1834 Don't redact KuduRowResult::ToString()
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/6222/1/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:
PS1, Line 1087: bool old_tls_redact_user_data = tls_redact_user_data;
: bool old_should_redact_log = g_should_redact_log;
: bool old_g_should_redact_flag = g_should_redact_flag;
: tls_redact_user_data = true;
: g_should_redact_log = true;
: g_should_redact_flag = true;
> Would be simpler to redact via google::SetCommandLineOption(); it'll cause
Done
Line 1093: ASSERT_NO_FATAL_FAILURE(InsertTestRows(client_table_.get(),
> Nit: use the shorter NO_FATALS() in new code.
Done
http://gerrit.cloudera.org:8080/#/c/6222/1/src/kudu/client/scan_batch.cc
File src/kudu/client/scan_batch.cc:
Line 288: ScopedDisableRedaction no_redaction;
> Add a short comment here justifying it.
Done
--
To view, visit http://gerrit.cloudera.org:8080/6222
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If966e9ba76f747de85350ffa2b91fcf05a9ad324
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1834 Don't redact KuduRowResult::ToString()
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6222
to look at the new patch set (#2).
Change subject: KUDU-1834 Don't redact KuduRowResult::ToString()
......................................................................
KUDU-1834 Don't redact KuduRowResult::ToString()
A user on the client side calling ToString on the results of a scan
will likely expect the data to not be redacted. This patch forces
KuduScanPatch::RowPtr::ToString() to not redact.
A test case is added to client-test that turns redaction on and
compares the output of ToString with a redacted row. If the row is
redacted, this case fill fail.
Change-Id: If966e9ba76f747de85350ffa2b91fcf05a9ad324
---
M src/kudu/client/client-test.cc
M src/kudu/client/scan_batch.cc
2 files changed, 22 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/6222/2
--
To view, visit http://gerrit.cloudera.org:8080/6222
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If966e9ba76f747de85350ffa2b91fcf05a9ad324
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-1834 Don't redact KuduRowResult::ToString()
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: KUDU-1834 Don't redact KuduRowResult::ToString()
......................................................................
KUDU-1834 Don't redact KuduRowResult::ToString()
A user on the client side calling ToString on the results of a scan
will likely expect the data to not be redacted. This patch forces
KuduScanPatch::RowPtr::ToString() to not redact.
A test case is added to client-test that turns redaction on and
compares the output of ToString with a redacted row. If the row is
redacted, this case fill fail.
Change-Id: If966e9ba76f747de85350ffa2b91fcf05a9ad324
Reviewed-on: http://gerrit.cloudera.org:8080/6222
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/client/client-test.cc
M src/kudu/client/scan_batch.cc
2 files changed, 22 insertions(+), 0 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6222
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If966e9ba76f747de85350ffa2b91fcf05a9ad324
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-1834 Don't redact KuduRowResult::ToString()
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: KUDU-1834 Don't redact KuduRowResult::ToString()
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/6222/1/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:
PS1, Line 1087: bool old_tls_redact_user_data = tls_redact_user_data;
: bool old_should_redact_log = g_should_redact_log;
: bool old_g_should_redact_flag = g_should_redact_flag;
: tls_redact_user_data = true;
: g_should_redact_log = true;
: g_should_redact_flag = true;
Would be simpler to redact via google::SetCommandLineOption(); it'll cause the validators to be called again. Plus you don't need to store/restore the old values; it'll be taken care of via a FlagSaver I believe.
Line 1093: ASSERT_NO_FATAL_FAILURE(InsertTestRows(client_table_.get(),
Nit: use the shorter NO_FATALS() in new code.
http://gerrit.cloudera.org:8080/#/c/6222/1/src/kudu/client/scan_batch.cc
File src/kudu/client/scan_batch.cc:
Line 288: ScopedDisableRedaction no_redaction;
Add a short comment here justifying it.
--
To view, visit http://gerrit.cloudera.org:8080/6222
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If966e9ba76f747de85350ffa2b91fcf05a9ad324
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes