You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/01/05 06:26:00 UTC
[jira] [Commented] (HADOOP-18320) Improve S3A delegations token documentation
[ https://issues.apache.org/jira/browse/HADOOP-18320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654782#comment-17654782 ]
ASF GitHub Bot commented on HADOOP-18320:
-----------------------------------------
mukund-thakur commented on code in PR #4499:
URL: https://github.com/apache/hadoop/pull/4499#discussion_r1062124836
##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/delegation_tokens.md:
##########
@@ -108,7 +108,7 @@ password-protected data opaque to clients; they contain the secrets needed
to access the relevant S3 buckets and associated services.
They are obtained by requesting a delegation token from the S3A filesystem client.
Review Comment:
Not sure why github not allowing me to comment at L82.
Delegation "Token" support is
##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/delegation_tokens.md:
##########
@@ -108,7 +108,7 @@ password-protected data opaque to clients; they contain the secrets needed
to access the relevant S3 buckets and associated services.
They are obtained by requesting a delegation token from the S3A filesystem client.
Review Comment:
l120 : It -> it.
##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/delegation_tokens.md:
##########
@@ -108,7 +108,7 @@ password-protected data opaque to clients; they contain the secrets needed
to access the relevant S3 buckets and associated services.
They are obtained by requesting a delegation token from the S3A filesystem client.
Review Comment:
L106 -> These S3A Delegation Tokens are special in "a way" that
##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/delegation_tokens.md:
##########
@@ -353,10 +352,10 @@ it is authenticated with; the role token binding will fail.
When the AWS credentials supplied to the Session Delegation Token binding
through `fs.s3a.aws.credentials.provider` are themselves a set of
Review Comment:
Something is off here, maybe "they themselves are part of session credentials."
> Improve S3A delegations token documentation
> -------------------------------------------
>
> Key: HADOOP-18320
> URL: https://issues.apache.org/jira/browse/HADOOP-18320
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Ahmar Suhail
> Assignee: Ahmar Suhail
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The current [delegations token documentation|https://github.com/apache/hadoop/blob/trunk/hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/delegation_tokens.md] has some typos, this task tracks fixing those.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org