[GitHub] [ozone] umamaheswararao commented on pull request #1973: HDDS-4882. Modify proto file with container metadata and replication config

[GitBox <gi...@apache.org>]

umamaheswararao commented on pull request #1973:
URL: https://github.com/apache/ozone/pull/1973#issuecomment-796907320


   @elek 
   
   >Until now, I have strong concerns about the bitmasking approach but others (including Uma) said that but approach fine with them, so this seems to be Less Common Denominator.
   
   But none of the reasons really technical concerns to me. Example: you said backward compatibility issue. It's not valid, unless you did not get the proposal fully. In the JIRA, in one of the doc you have listed and we [discussed](https://issues.apache.org/jira/browse/HDDS-3816?focusedCommentId=17242065&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17242065)
   It seems that it's your opinion that you feel it's complex and you feel hard to follow the bitmasking ops. We need not assume the same case with everyone as we have proved that working in hadoop where we have started ozone as subproject. 
   
   Since you are strongly willing to do the separated index, please go ahead and provide the patch with clear analysis. It does not mean that I am agreeing with your concerns what you have on bit masking. I am still saying they are not really valid concerns for me. Except the point, you said it's complex for you. It's a subjective, I cannot judge others understanding :-) . We just need to move forward and not really worth spending much time on this small part, which will block everything.
   
   Here are some inputs for your analysis: we need to create the blockOutputStreams to different nodes by passing, BlockID(containerID, localID). Here we must include the index as well, so that datanode knows and report the index to SCM. With bit asking this happens implicitly. Since you are trying index based approach here, we need to pass it explicitly. Let me know if your thought is different.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org