[PR] Fixed: ModelService copy constructor shares the cached service's parameter map and drops required-permissions and notifications (OFBIZ-13781) [ofbiz-framework]

["mridulpathak (via GitHub) via notifications" <no...@ofbiz.apache.org>]

mridulpathak opened a new pull request, #2526:
URL: https://github.com/apache/ofbiz-framework/pull/2526

   The ModelService copy constructor is used by runSync, runSyncIgnore and runAsync when a transaction timeout or a new transaction is requested, which includes every minilang call-service. It reused the cached service's parameter map and put the copy's cloned parameters into it, so after one such call the cached service returned that call's clones. It also left out the required permissions, the notifications and the deprecation details, so those calls skipped the service's required-permissions check and sent no notifications. The copy now has its own parameter map and copies these fields.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fixed: ModelService copy constructor shares the cached service's parameter map and drops required-permissions and notifications (OFBIZ-13781) [ofbiz-framework]

["mridulpathak (via GitHub) via notifications" <no...@ofbiz.apache.org>]

mridulpathak merged PR #2526:
URL: https://github.com/apache/ofbiz-framework/pull/2526


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org