[GitHub] [doris] nextdreamblue commented on a diff in pull request #15018: [fix](merge-on-write) calc delete bitmap need all segments which _do_flush in one memtable

[GitBox <gi...@apache.org>]

nextdreamblue commented on code in PR #15018:
URL: https://github.com/apache/doris/pull/15018#discussion_r1045667912


##########
be/src/olap/rowset/rowset_writer.h:
##########
@@ -62,10 +62,12 @@ class RowsetWriter {
     virtual Status flush_columns() { return Status::Error<ErrorCode::NOT_IMPLEMENTED_ERROR>(); }
     virtual Status final_flush() { return Status::Error<ErrorCode::NOT_IMPLEMENTED_ERROR>(); }
 
-    virtual Status flush_single_memtable(MemTable* memtable, int64_t* flush_size) {
+    virtual Status flush_single_memtable(MemTable* memtable, int64_t* flush_size,
+                                         std::vector<int64_t>* seg_ids_for_delete_bitmap) {

Review Comment:
   ok
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org