You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2021/02/05 18:18:44 UTC

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #1133: PHOENIX-6365 Bogus AmbiguousTableException in query with aliases on l…

gjacoby126 commented on a change in pull request #1133:
URL: https://github.com/apache/phoenix/pull/1133#discussion_r571159922



##########
File path: phoenix-core/src/main/java/org/apache/phoenix/compile/FromCompiler.java
##########
@@ -893,15 +893,14 @@ public Void visit(NamedTableNode tableNode) throws SQLException {
             TableRef tableRef = createTableRef(connectionSchemaName, tableNode, true, false);
             PTable theTable = tableRef.getTable();
 
+            String name = theTable.getName().getString();

Review comment:
       nit: maybe extract this logic to a private helper function so it doesn't have to be duplicated in two places




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org