You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2021/05/11 17:02:56 UTC
[GitHub] [qpid-dispatch] ganeshmurthy opened a new pull request #1210: DISPATCH-2113: Removed all relative path references in system tests
ganeshmurthy opened a new pull request #1210:
URL: https://github.com/apache/qpid-dispatch/pull/1210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #1210: DISPATCH-2113: Removed all relative path references in system tests
Posted by GitBox <gi...@apache.org>.
kgiusti commented on a change in pull request #1210:
URL: https://github.com/apache/qpid-dispatch/pull/1210#discussion_r630440862
##########
File path: tests/system_tests_protocol_settings.py
##########
@@ -83,8 +84,8 @@ def test_max_sessions(self):
bc = BlockingConnection(self.router.addresses[0])
bc.create_receiver("xxx")
bc.close()
-
- with open('../setUpClass/MaxSessions.log', 'r') as router_log:
+ logfile = os.path.join(self.router.outdir, self.router.logfile)
Review comment:
why not just use router.logfile_path like you did in other places?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #1210: DISPATCH-2113: Removed all relative path references in system tests
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1210:
URL: https://github.com/apache/qpid-dispatch/pull/1210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #1210: DISPATCH-2113: Removed all relative path references in system tests
Posted by GitBox <gi...@apache.org>.
ganeshmurthy commented on a change in pull request #1210:
URL: https://github.com/apache/qpid-dispatch/pull/1210#discussion_r630455722
##########
File path: tests/system_tests_protocol_settings.py
##########
@@ -83,8 +84,8 @@ def test_max_sessions(self):
bc = BlockingConnection(self.router.addresses[0])
bc.create_receiver("xxx")
bc.close()
-
- with open('../setUpClass/MaxSessions.log', 'r') as router_log:
+ logfile = os.path.join(self.router.outdir, self.router.logfile)
Review comment:
Not sure how I missed that one. I fixed it. Thanks !!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org