You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by jr...@apache.org on 2018/03/14 20:50:37 UTC
[03/14] qpid-cpp git commit: QPID-7630: Add a CMake switch to allow
-Werror to be switched off
QPID-7630: Add a CMake switch to allow -Werror to be switched off
Project: http://git-wip-us.apache.org/repos/asf/qpid-cpp/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-cpp/commit/5d28224e
Tree: http://git-wip-us.apache.org/repos/asf/qpid-cpp/tree/5d28224e
Diff: http://git-wip-us.apache.org/repos/asf/qpid-cpp/diff/5d28224e
Branch: refs/heads/master
Commit: 5d28224e6108136284ebef9a23a01d1e226d1404
Parents: cd6cad7
Author: Justin Ross <jr...@apache.org>
Authored: Mon Mar 12 16:37:14 2018 -0700
Committer: Justin Ross <jr...@apache.org>
Committed: Wed Mar 14 10:46:27 2018 -0700
----------------------------------------------------------------------
CMakeLists.txt | 2 +-
src/CMakeLists.txt | 8 ++++----
2 files changed, 5 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/qpid-cpp/blob/5d28224e/CMakeLists.txt
----------------------------------------------------------------------
diff --git a/CMakeLists.txt b/CMakeLists.txt
index d0b8b1f..c99bced 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -147,7 +147,7 @@ if (CMAKE_CXX_COMPILER_ID STREQUAL GNU)
# -Wunreachable-code -Wpadded -Winline
# -Wshadow - warns about boost headers.
set (WARNING_FLAGS
- "-Werror -pedantic -Wall -Wextra -Wno-shadow -Wpointer-arith -Wcast-qual -Wcast-align -Wno-long-long -Wvolatile-register-var -Winvalid-pch -Wno-system-headers -Woverloaded-virtual -Wno-deprecated-declarations")
+ "-pedantic -Wall -Wextra -Wno-shadow -Wpointer-arith -Wcast-qual -Wcast-align -Wno-long-long -Wvolatile-register-var -Winvalid-pch -Wno-system-headers -Woverloaded-virtual -Wno-deprecated-declarations")
if (CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 7)
set(WARNING_FLAGS "${WARNING_FLAGS} -Wno-implicit-fallthrough")
http://git-wip-us.apache.org/repos/asf/qpid-cpp/blob/5d28224e/src/CMakeLists.txt
----------------------------------------------------------------------
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 44a39b8..f7e69ea 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -151,10 +151,10 @@ if (VALGRIND_FOUND)
option(ENABLE_VALGRIND "Use valgrind to detect run-time problems" ON)
endif (VALGRIND_FOUND)
-option(ENABLE_WARNINGS "Enable lots of compiler warnings (recommended)" ON)
-if (NOT ENABLE_WARNINGS)
- set (WARNING_FLAGS "")
-endif (NOT ENABLE_WARNINGS)
+option(ENABLE_WARNING_ERROR "Consider compiler warnings to be errors" ON)
+if (ENABLE_WARNING_ERROR)
+ set(WARNING_FLAGS "${WARNING_FLAGS} -Werror")
+endif (ENABLE_WARNING_ERROR)
if (GCC_VERSION AND NOT GCC_VERSION VERSION_LESS 5.1)
option(ENABLE_GLIBCXX_OLD_ABI "Enable old (pre GCC 5.1) C++ ABI" OFF)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org