You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by carsonwang <gi...@git.apache.org> on 2017/04/05 05:35:12 UTC

[GitHub] spark pull request #17535: [SPARK-20222][SQL] Bring back the Spark SQL UI wh...

GitHub user carsonwang opened a pull request:

    https://github.com/apache/spark/pull/17535

    [SPARK-20222][SQL] Bring back the Spark SQL UI when executing queries in Spark SQL CLI

    ## What changes were proposed in this pull request?
    There is no Spark SQL UI when executing queries in Spark SQL CLI. It worked before in 2.1.0.
    The method `hiveResultString` is used by `SparkSQLDriver`. It seems the line `SQLExecution.withNewExecutionId` was removed accidently. This PR is to bring the SQL UI back when using Spark SQL CLI.
    
    ## How was this patch tested?
    Manually ran bin/spark-sql and executed a query. 


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/carsonwang/spark sqlUIFix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/17535.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #17535
    
----
commit 1d843afb9e5a49f429f5723973d0a0457cf36b3b
Author: Carson Wang <ca...@intel.com>
Date:   2017-04-05T02:41:42Z

    Show Spark SQL UI when using spark sql cli

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17535: [SPARK-20222][SQL] Bring back the Spark SQL UI when exec...

Posted by carsonwang <gi...@git.apache.org>.
Github user carsonwang commented on the issue:

    https://github.com/apache/spark/pull/17535
  
    Yes, it is closely related but two scenarios of adding `SQLExecution.withNewExecutionId`.
    Now some tests fail because `withNewExecutionId` is called twice.
    ```
    java.lang.IllegalArgumentException: spark.sql.execution.id is already set
    [info]   	at org.apache.spark.sql.execution.SQLExecution$.withNewExecutionId(SQLExecution.scala:90)
    [info]   	at org.apache.spark.sql.execution.datasources.FileFormatWriter$.write(FileFormatWriter.scala:164)
    [info]   	at org.apache.spark.sql.hive.execution.InsertIntoHiveTable.run(InsertIntoHiveTable.scala:311)
    [info]   	at org.apache.spark.sql.execution.command.ExecutedCommandExec.sideEffectResult$lzycompute(commands.scala:58)
    [info]   	at org.apache.spark.sql.execution.command.ExecutedCommandExec.sideEffectResult(commands.scala:56)
    [info]   	at org.apache.spark.sql.execution.command.ExecutedCommandExec.executeCollect(commands.scala:67)
    [info]   	at org.apache.spark.sql.execution.SparkPlan.executeCollectPublic(SparkPlan.scala:295)
    [info]   	at org.apache.spark.sql.execution.QueryExecution$$anonfun$hiveResultString$3.apply(QueryExecution.scala:137)
    [info]   	at org.apache.spark.sql.execution.QueryExecution$$anonfun$hiveResultString$3.apply(QueryExecution.scala:136)
    [info]   	at org.apache.spark.sql.execution.SQLExecution$.withNewExecutionId(SQLExecution.scala:65)
    [info]   	at org.apache.spark.sql.execution.QueryExecution.hiveResultString(QueryExecution.scala:136)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17535: [SPARK-20222][SQL] Bring back the Spark SQL UI when exec...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17535
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75533/
    Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17535: [SPARK-20222][SQL] Bring back the Spark SQL UI when exec...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17535
  
    Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17535: [SPARK-20222][SQL] Bring back the Spark SQL UI when exec...

Posted by carsonwang <gi...@git.apache.org>.
Github user carsonwang commented on the issue:

    https://github.com/apache/spark/pull/17535
  
    This fix will be included in #17540 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17535: [SPARK-20222][SQL] Bring back the Spark SQL UI when exec...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17535
  
    **[Test build #75533 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75533/testReport)** for PR 17535 at commit [`1d843af`](https://github.com/apache/spark/commit/1d843afb9e5a49f429f5723973d0a0457cf36b3b).
     * This patch **fails Spark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17535: [SPARK-20222][SQL] Bring back the Spark SQL UI when exec...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17535
  
    **[Test build #75533 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75533/testReport)** for PR 17535 at commit [`1d843af`](https://github.com/apache/spark/commit/1d843afb9e5a49f429f5723973d0a0457cf36b3b).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #17535: [SPARK-20222][SQL] Bring back the Spark SQL UI wh...

Posted by carsonwang <gi...@git.apache.org>.
Github user carsonwang closed the pull request at:

    https://github.com/apache/spark/pull/17535


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17535: [SPARK-20222][SQL] Bring back the Spark SQL UI when exec...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/17535
  
    Looks closely related to https://github.com/apache/spark/pull/17540 ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org