You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zihao Ye (Code Review)" <ge...@cloudera.org> on 2024/12/02 11:15:05 UTC
[Impala-ASF-CR] IMPALA-13590: Use CacheLineAligned instead of CACHELINE ALIGNED for PerFilterState
Zihao Ye has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22147
Change subject: IMPALA-13590: Use CacheLineAligned instead of CACHELINE_ALIGNED for PerFilterState
......................................................................
IMPALA-13590: Use CacheLineAligned instead of CACHELINE_ALIGNED for PerFilterState
Currently, class PerFilterState is marked with CACHELINE_ALIGNED, which
is actually a macro definition of __attribute__((aligned())). For static
allocation, it can specify memory alignment, but it cannot specify
alignment for dynamic memory allocation. In the code, all PerFilterState
objects are dynamically created using make_unique in the function
RuntimeFilterBank::BuildFilterMap(), so CACHELINE_ALIGNED does not
really have any effect. It might even lead to unexpected situations as
described in the JIRA comments.
Therefore, this patch replaces CACHELINE_ALIGNED with CacheLineAligned,
which supports alignment for dynamic memory allocation.
Testing:
- Existing tests cover this change.
Change-Id: I0d119679b1d446cb69f6eec595def2d40cb6d1ff
---
M be/src/runtime/runtime-filter-bank.h
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/22147/1
--
To view, visit http://gerrit.cloudera.org:8080/22147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0d119679b1d446cb69f6eec595def2d40cb6d1ff
Gerrit-Change-Number: 22147
Gerrit-PatchSet: 1
Gerrit-Owner: Zihao Ye <ey...@163.com>
[Impala-ASF-CR] IMPALA-13590: Use CacheLineAligned instead of CACHELINE ALIGNED for PerFilterState
Posted by "Zihao Ye (Code Review)" <ge...@cloudera.org>.
Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/22147 )
Change subject: IMPALA-13590: Use CacheLineAligned instead of CACHELINE_ALIGNED for PerFilterState
......................................................................
Patch Set 2:
It seems that some unrelated flaky tests were hit.
--
To view, visit http://gerrit.cloudera.org:8080/22147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d119679b1d446cb69f6eec595def2d40cb6d1ff
Gerrit-Change-Number: 22147
Gerrit-PatchSet: 2
Gerrit-Owner: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 12 Dec 2024 03:08:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13590: Use CacheLineAligned instead of CACHELINE ALIGNED for PerFilterState
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22147 )
Change subject: IMPALA-13590: Use CacheLineAligned instead of CACHELINE_ALIGNED for PerFilterState
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11185/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/22147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d119679b1d446cb69f6eec595def2d40cb6d1ff
Gerrit-Change-Number: 22147
Gerrit-PatchSet: 1
Gerrit-Owner: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Dec 2024 11:50:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13590: Use CacheLineAligned instead of CACHELINE ALIGNED for PerFilterState
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22147 )
Change subject: IMPALA-13590: Use CacheLineAligned instead of CACHELINE_ALIGNED for PerFilterState
......................................................................
IMPALA-13590: Use CacheLineAligned instead of CACHELINE_ALIGNED for PerFilterState
Currently, class PerFilterState is marked with CACHELINE_ALIGNED, which
is actually a macro definition of __attribute__((aligned())). For static
allocation, it can specify memory alignment, but it cannot specify
alignment for dynamic memory allocation. In the code, all PerFilterState
objects are dynamically created using make_unique in the function
RuntimeFilterBank::BuildFilterMap(), so CACHELINE_ALIGNED does not
really have any effect. It might even lead to unexpected situations as
described in the JIRA comments.
Therefore, this patch replaces CACHELINE_ALIGNED with CacheLineAligned,
which supports alignment for dynamic memory allocation.
Testing:
- Existing tests cover this change.
Change-Id: I0d119679b1d446cb69f6eec595def2d40cb6d1ff
Reviewed-on: http://gerrit.cloudera.org:8080/22147
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/runtime/runtime-filter-bank.h
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/22147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0d119679b1d446cb69f6eec595def2d40cb6d1ff
Gerrit-Change-Number: 22147
Gerrit-PatchSet: 4
Gerrit-Owner: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-13590: Use CacheLineAligned instead of CACHELINE ALIGNED for PerFilterState
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22147 )
Change subject: IMPALA-13590: Use CacheLineAligned instead of CACHELINE_ALIGNED for PerFilterState
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/11196/
--
To view, visit http://gerrit.cloudera.org:8080/22147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d119679b1d446cb69f6eec595def2d40cb6d1ff
Gerrit-Change-Number: 22147
Gerrit-PatchSet: 2
Gerrit-Owner: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 11 Dec 2024 19:25:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13590: Use CacheLineAligned instead of CACHELINE ALIGNED for PerFilterState
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22147 )
Change subject: IMPALA-13590: Use CacheLineAligned instead of CACHELINE_ALIGNED for PerFilterState
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11196/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/22147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d119679b1d446cb69f6eec595def2d40cb6d1ff
Gerrit-Change-Number: 22147
Gerrit-PatchSet: 2
Gerrit-Owner: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 11 Dec 2024 13:55:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13590: Use CacheLineAligned instead of CACHELINE ALIGNED for PerFilterState
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22147 )
Change subject: IMPALA-13590: Use CacheLineAligned instead of CACHELINE_ALIGNED for PerFilterState
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d119679b1d446cb69f6eec595def2d40cb6d1ff
Gerrit-Change-Number: 22147
Gerrit-PatchSet: 1
Gerrit-Owner: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 11 Dec 2024 13:54:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13590: Use CacheLineAligned instead of CACHELINE ALIGNED for PerFilterState
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22147 )
Change subject: IMPALA-13590: Use CacheLineAligned instead of CACHELINE_ALIGNED for PerFilterState
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d119679b1d446cb69f6eec595def2d40cb6d1ff
Gerrit-Change-Number: 22147
Gerrit-PatchSet: 2
Gerrit-Owner: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 11 Dec 2024 13:55:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13590: Use CacheLineAligned instead of CACHELINE ALIGNED for PerFilterState
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22147 )
Change subject: IMPALA-13590: Use CacheLineAligned instead of CACHELINE_ALIGNED for PerFilterState
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11198/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/22147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d119679b1d446cb69f6eec595def2d40cb6d1ff
Gerrit-Change-Number: 22147
Gerrit-PatchSet: 3
Gerrit-Owner: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 12 Dec 2024 03:10:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13590: Use CacheLineAligned instead of CACHELINE ALIGNED for PerFilterState
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22147 )
Change subject: IMPALA-13590: Use CacheLineAligned instead of CACHELINE_ALIGNED for PerFilterState
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/17611/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d119679b1d446cb69f6eec595def2d40cb6d1ff
Gerrit-Change-Number: 22147
Gerrit-PatchSet: 1
Gerrit-Owner: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Dec 2024 11:41:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13590: Use CacheLineAligned instead of CACHELINE ALIGNED for PerFilterState
Posted by "ttttttz (Code Review)" <ge...@cloudera.org>.
ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/22147 )
Change subject: IMPALA-13590: Use CacheLineAligned instead of CACHELINE_ALIGNED for PerFilterState
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/22147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d119679b1d446cb69f6eec595def2d40cb6d1ff
Gerrit-Change-Number: 22147
Gerrit-PatchSet: 1
Gerrit-Owner: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Wed, 11 Dec 2024 10:17:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13590: Use CacheLineAligned instead of CACHELINE ALIGNED for PerFilterState
Posted by "Zihao Ye (Code Review)" <ge...@cloudera.org>.
Zihao Ye has removed a vote on this change.
Change subject: IMPALA-13590: Use CacheLineAligned instead of CACHELINE_ALIGNED for PerFilterState
......................................................................
Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
--
To view, visit http://gerrit.cloudera.org:8080/22147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I0d119679b1d446cb69f6eec595def2d40cb6d1ff
Gerrit-Change-Number: 22147
Gerrit-PatchSet: 2
Gerrit-Owner: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
[Impala-ASF-CR] IMPALA-13590: Use CacheLineAligned instead of CACHELINE ALIGNED for PerFilterState
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22147 )
Change subject: IMPALA-13590: Use CacheLineAligned instead of CACHELINE_ALIGNED for PerFilterState
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d119679b1d446cb69f6eec595def2d40cb6d1ff
Gerrit-Change-Number: 22147
Gerrit-PatchSet: 3
Gerrit-Owner: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 12 Dec 2024 03:10:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13590: Use CacheLineAligned instead of CACHELINE ALIGNED for PerFilterState
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22147 )
Change subject: IMPALA-13590: Use CacheLineAligned instead of CACHELINE_ALIGNED for PerFilterState
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/22147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d119679b1d446cb69f6eec595def2d40cb6d1ff
Gerrit-Change-Number: 22147
Gerrit-PatchSet: 3
Gerrit-Owner: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: ttttttz <24...@qq.com>
Gerrit-Comment-Date: Thu, 12 Dec 2024 08:39:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13590: Use CacheLineAligned instead of CACHELINE ALIGNED for PerFilterState
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22147 )
Change subject: IMPALA-13590: Use CacheLineAligned instead of CACHELINE_ALIGNED for PerFilterState
......................................................................
Patch Set 1: Code-Review+1
This looks OK to me.
Have you test compiling in your target OS?
--
To view, visit http://gerrit.cloudera.org:8080/22147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d119679b1d446cb69f6eec595def2d40cb6d1ff
Gerrit-Change-Number: 22147
Gerrit-PatchSet: 1
Gerrit-Owner: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Dec 2024 17:25:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13590: Use CacheLineAligned instead of CACHELINE ALIGNED for PerFilterState
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22147 )
Change subject: IMPALA-13590: Use CacheLineAligned instead of CACHELINE_ALIGNED for PerFilterState
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/22147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d119679b1d446cb69f6eec595def2d40cb6d1ff
Gerrit-Change-Number: 22147
Gerrit-PatchSet: 1
Gerrit-Owner: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Dec 2024 17:22:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13590: Use CacheLineAligned instead of CACHELINE ALIGNED for PerFilterState
Posted by "Zihao Ye (Code Review)" <ge...@cloudera.org>.
Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/22147 )
Change subject: IMPALA-13590: Use CacheLineAligned instead of CACHELINE_ALIGNED for PerFilterState
......................................................................
Patch Set 1:
Thank you for the review. I do not have the conditions to perform such tests, however, I have verified that using CacheLineAligned does not cause any issues on the target OS, even when compiled on CentOS.
--
To view, visit http://gerrit.cloudera.org:8080/22147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d119679b1d446cb69f6eec595def2d40cb6d1ff
Gerrit-Change-Number: 22147
Gerrit-PatchSet: 1
Gerrit-Owner: Zihao Ye <ey...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Tue, 03 Dec 2024 05:47:46 +0000
Gerrit-HasComments: No