You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/08/11 02:30:01 UTC
[GitHub] [hive] sam-an-cloudera opened a new pull request #1385: HIVE-24022: Optimise HiveMetaStoreAuthorizer.createHiveMetaStoreAutho…
sam-an-cloudera opened a new pull request #1385:
URL: https://github.com/apache/hive/pull/1385
They are many calls to createHiveMetastoreAuthorizer, and for each call, we are creating HiveConf, which is slow. We can use the ThreadLocal conf, so that each thread only creates it once.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] closed pull request #1385: HIVE-24022: Optimise HiveMetaStoreAuthorizer.createHiveMetaStoreAutho…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #1385:
URL: https://github.com/apache/hive/pull/1385
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] nrg4878 commented on pull request #1385: HIVE-24022: Optimise HiveMetaStoreAuthorizer.createHiveMetaStoreAutho…
Posted by GitBox <gi...@apache.org>.
nrg4878 commented on pull request #1385:
URL: https://github.com/apache/hive/pull/1385#issuecomment-691213984
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] nrg4878 commented on pull request #1385: HIVE-24022: Optimise HiveMetaStoreAuthorizer.createHiveMetaStoreAutho…
Posted by GitBox <gi...@apache.org>.
nrg4878 commented on pull request #1385:
URL: https://github.com/apache/hive/pull/1385#issuecomment-691213984
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #1385: HIVE-24022: Optimise HiveMetaStoreAuthorizer.createHiveMetaStoreAutho…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1385:
URL: https://github.com/apache/hive/pull/1385#issuecomment-725051526
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] nrg4878 commented on pull request #1385: HIVE-24022: Optimise HiveMetaStoreAuthorizer.createHiveMetaStoreAutho…
Posted by GitBox <gi...@apache.org>.
nrg4878 commented on pull request #1385:
URL: https://github.com/apache/hive/pull/1385#issuecomment-683904667
@sam-an-cloudera initialValue() return type was Configuration and is now HiveConf which is a sub-class of Configuration. Was there a reason for this change? It would be more appropriate that the return type be Configuration. Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] nrg4878 commented on pull request #1385: HIVE-24022: Optimise HiveMetaStoreAuthorizer.createHiveMetaStoreAutho…
Posted by GitBox <gi...@apache.org>.
nrg4878 commented on pull request #1385:
URL: https://github.com/apache/hive/pull/1385#issuecomment-691213984
Fix has been committed to master. Thanks for the fix @sam-an-cloudera
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sam-an-cloudera commented on pull request #1385: HIVE-24022: Optimise HiveMetaStoreAuthorizer.createHiveMetaStoreAutho…
Posted by GitBox <gi...@apache.org>.
sam-an-cloudera commented on pull request #1385:
URL: https://github.com/apache/hive/pull/1385#issuecomment-683950735
> @sam-an-cloudera initialValue() return type was Configuration and is now HiveConf which is a sub-class of Configuration. Was there a reason for this change? It would be more appropriate that the return type be Configuration. Thoughts?
It was mainly to avoid having to cast. The config used in createHiveMetastoreAuthorizer( ) method is required to be a HiveConf, the createHiveAuthorizer( ) call in particular. If we keep it as Configuration, then down there we have to do a cast, which is not good style, so I changed the original to HiveConf.
HiveConf hiveConf = tConfig.get();
if(hiveConf == null){
HiveConf hiveConf1 = new HiveConf(super.getConf(), HiveConf.class); <==If I don't change, then here would need a cast.
tConfig.set(hiveConf1);
hiveConf = hiveConf1;
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org