You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Joe Orton <jo...@redhat.com> on 2013/07/09 17:47:37 UTC
Re: [PATCH] Fix "LDAPReferrals off"
On Thu, Jun 20, 2013 at 08:41:04AM -0400, Eric Covener wrote:
> I'm only concerned with someone who was getting by with LDAPReferrals
> OFF because the default gave their SDK an error. Now OFF would be
> fatal too.
Just revisiting this... at least it seems clear that the docs do not
match the code here, in that "LDAPRerrals off" does something
surprising. So what are the choices?
a) Jan's suggestion: offer a tri-state option on/off/default where
"default" is equivalent to current "off".
b) change the docs so that it is not implied that "LDAPReferrals off"
really disables referral processing.
c) ...something else?
> But it's not so easy to do a separate "default" option because other
> parts of the code need to know if referrals are being chased.
I don't follow that: if the intent here is retaining the current
behaviour of "LDAPReferrals off" for users who want that, then we can do
that easily.
Regards, Joe
Re: [PATCH] Fix "LDAPReferrals off"
Posted by Eric Covener <co...@gmail.com>.
>> One of us still owes doc.
> Patch attached.
Thanks -- I committed it with some changes to break up the paragraph into a <dl>
Re: [PATCH] Fix "LDAPReferrals off"
Posted by Jan Kaluža <jk...@redhat.com>.
On 08/26/2013 12:43 AM, Eric Covener wrote:
> Sorry, just got to it in 1517388. At the last second I did a
> s/unset/default (both are kind of misleading in their own way) -- let
> me know if you hate the change and I can put it back.
Thanks for the commit. This looks OK.
> One of us still owes doc.
Patch attached.
> On Thu, Aug 22, 2013 at 8:29 AM, Jan Kaluža <jk...@redhat.com> wrote:
>> On 07/10/2013 02:39 PM, Eric Covener wrote:
>>>>
>>>> attached patch changes LDAPReferrals to tri-state logic.
>>>>
>>>> - "on" - default. Calls apr_ldap_set_option to set referrals on.
>>>> - "off" - Calls apr_ldap_set_option to turn referrals off.
>>>> - "unset" - Does not call apr_ldap_set_option at all.
>>>
>>>
>>> +1, will let it stew here first and commit soon. PR54358 followup will
>>> maybe provide something to further control how unset (== enabled on
>>> openldap) will chase referrals but w/o rebind callback.
>>>
>>
>> Hi, any luck with my patch? Do you have some comments regarding it? I would
>> really like to see this fixed also upstream :).
>>
>> Regards,
>> Jan Kaluza
>>
>
>
>
Jan Kaluza
Re: [PATCH] Fix "LDAPReferrals off"
Posted by Eric Covener <co...@gmail.com>.
Sorry, just got to it in 1517388. At the last second I did a
s/unset/default (both are kind of misleading in their own way) -- let
me know if you hate the change and I can put it back.
One of us still owes doc.
On Thu, Aug 22, 2013 at 8:29 AM, Jan Kaluža <jk...@redhat.com> wrote:
> On 07/10/2013 02:39 PM, Eric Covener wrote:
>>>
>>> attached patch changes LDAPReferrals to tri-state logic.
>>>
>>> - "on" - default. Calls apr_ldap_set_option to set referrals on.
>>> - "off" - Calls apr_ldap_set_option to turn referrals off.
>>> - "unset" - Does not call apr_ldap_set_option at all.
>>
>>
>> +1, will let it stew here first and commit soon. PR54358 followup will
>> maybe provide something to further control how unset (== enabled on
>> openldap) will chase referrals but w/o rebind callback.
>>
>
> Hi, any luck with my patch? Do you have some comments regarding it? I would
> really like to see this fixed also upstream :).
>
> Regards,
> Jan Kaluza
>
--
Eric Covener
covener@gmail.com
Re: [PATCH] Fix "LDAPReferrals off"
Posted by Jan Kaluža <jk...@redhat.com>.
On 07/10/2013 02:39 PM, Eric Covener wrote:
>> attached patch changes LDAPReferrals to tri-state logic.
>>
>> - "on" - default. Calls apr_ldap_set_option to set referrals on.
>> - "off" - Calls apr_ldap_set_option to turn referrals off.
>> - "unset" - Does not call apr_ldap_set_option at all.
>
> +1, will let it stew here first and commit soon. PR54358 followup will
> maybe provide something to further control how unset (== enabled on
> openldap) will chase referrals but w/o rebind callback.
>
Hi, any luck with my patch? Do you have some comments regarding it? I
would really like to see this fixed also upstream :).
Regards,
Jan Kaluza
Re: [PATCH] Fix "LDAPReferrals off"
Posted by Eric Covener <co...@gmail.com>.
> attached patch changes LDAPReferrals to tri-state logic.
>
> - "on" - default. Calls apr_ldap_set_option to set referrals on.
> - "off" - Calls apr_ldap_set_option to turn referrals off.
> - "unset" - Does not call apr_ldap_set_option at all.
+1, will let it stew here first and commit soon. PR54358 followup will
maybe provide something to further control how unset (== enabled on
openldap) will chase referrals but w/o rebind callback.
Re: [PATCH] Fix "LDAPReferrals off"
Posted by Jan Kaluža <jk...@redhat.com>.
On 07/10/2013 07:22 AM, Jan Kaluža wrote:
> On 07/09/2013 07:17 PM, Rainer Jung wrote:
>> On 09.07.2013 17:47, Joe Orton wrote:
>>> On Thu, Jun 20, 2013 at 08:41:04AM -0400, Eric Covener wrote:
>>>> I'm only concerned with someone who was getting by with LDAPReferrals
>>>> OFF because the default gave their SDK an error. Now OFF would be
>>>> fatal too.
>>>
>>> Just revisiting this... at least it seems clear that the docs do not
>>> match the code here, in that "LDAPRerrals off" does something
>>> surprising. So what are the choices?
>>>
>>> a) Jan's suggestion: offer a tri-state option on/off/default where
>>> "default" is equivalent to current "off".
Hi,
attached patch changes LDAPReferrals to tri-state logic.
- "on" - default. Calls apr_ldap_set_option to set referrals on.
- "off" - Calls apr_ldap_set_option to turn referrals off.
- "unset" - Does not call apr_ldap_set_option at all.
The "unset" option behaves like current "off" value (as implemented in
trunk) and can be used by admins who use LDAP implementation without
LDAP_OPT_REFERRALS support.
>>> b) change the docs so that it is not implied that "LDAPReferrals off"
>>> really disables referral processing.
>>>
>>> c) ...something else?
>>>
>>>> But it's not so easy to do a separate "default" option because other
>>>> parts of the code need to know if referrals are being chased.
>>>
>>> I don't follow that: if the intent here is retaining the current
>>> behaviour of "LDAPReferrals off" for users who want that, then we can do
>>> that easily.
>>
>> Sorry I didn't yet really follow this discussion, but see PR 54358 for a
>> maybe related issue (platform on which ldap referrals are not
>> implemented in apr and default "On" leads to status 500).
>
> Having tri-state logic (on/off/default) would fix this. If ldap
> referrals are not supported, you would to set it to "default" in config
> file and mod_ldap wouldn't try to do anything with ldap referrals.
>
> I'm going to submit a patch here later today.
>
>> Regards,
>>
>> Rainer
>>
>
> Regards,
> Jan Kaluza
>
Regards,
Jan Kaluza
Re: [PATCH] Fix "LDAPReferrals off"
Posted by Jan Kaluža <jk...@redhat.com>.
On 07/09/2013 07:17 PM, Rainer Jung wrote:
> On 09.07.2013 17:47, Joe Orton wrote:
>> On Thu, Jun 20, 2013 at 08:41:04AM -0400, Eric Covener wrote:
>>> I'm only concerned with someone who was getting by with LDAPReferrals
>>> OFF because the default gave their SDK an error. Now OFF would be
>>> fatal too.
>>
>> Just revisiting this... at least it seems clear that the docs do not
>> match the code here, in that "LDAPRerrals off" does something
>> surprising. So what are the choices?
>>
>> a) Jan's suggestion: offer a tri-state option on/off/default where
>> "default" is equivalent to current "off".
>>
>> b) change the docs so that it is not implied that "LDAPReferrals off"
>> really disables referral processing.
>>
>> c) ...something else?
>>
>>> But it's not so easy to do a separate "default" option because other
>>> parts of the code need to know if referrals are being chased.
>>
>> I don't follow that: if the intent here is retaining the current
>> behaviour of "LDAPReferrals off" for users who want that, then we can do
>> that easily.
>
> Sorry I didn't yet really follow this discussion, but see PR 54358 for a
> maybe related issue (platform on which ldap referrals are not
> implemented in apr and default "On" leads to status 500).
Having tri-state logic (on/off/default) would fix this. If ldap
referrals are not supported, you would to set it to "default" in config
file and mod_ldap wouldn't try to do anything with ldap referrals.
I'm going to submit a patch here later today.
> Regards,
>
> Rainer
>
Regards,
Jan Kaluza
Re: [PATCH] Fix "LDAPReferrals off"
Posted by Rainer Jung <ra...@kippdata.de>.
On 09.07.2013 17:47, Joe Orton wrote:
> On Thu, Jun 20, 2013 at 08:41:04AM -0400, Eric Covener wrote:
>> I'm only concerned with someone who was getting by with LDAPReferrals
>> OFF because the default gave their SDK an error. Now OFF would be
>> fatal too.
>
> Just revisiting this... at least it seems clear that the docs do not
> match the code here, in that "LDAPRerrals off" does something
> surprising. So what are the choices?
>
> a) Jan's suggestion: offer a tri-state option on/off/default where
> "default" is equivalent to current "off".
>
> b) change the docs so that it is not implied that "LDAPReferrals off"
> really disables referral processing.
>
> c) ...something else?
>
>> But it's not so easy to do a separate "default" option because other
>> parts of the code need to know if referrals are being chased.
>
> I don't follow that: if the intent here is retaining the current
> behaviour of "LDAPReferrals off" for users who want that, then we can do
> that easily.
Sorry I didn't yet really follow this discussion, but see PR 54358 for a
maybe related issue (platform on which ldap referrals are not
implemented in apr and default "On" leads to status 500).
Regards,
Rainer