[GitHub] [spark] bersprockets commented on issue #25068: [SPARK-28156][SQL][BACKPORT-2.4] Self-join should not miss cached view

[GitBox <gi...@apache.org>]

bersprockets commented on issue #25068: [SPARK-28156][SQL][BACKPORT-2.4] Self-join should not miss cached view
URL: https://github.com/apache/spark/pull/25068#issuecomment-509267901
 
 
   @viirya 
   
   Thanks for the comments. I was a little perplexed about the case where a back-ported PR needed a few small utility methods from other PRs: should I completely back-port the other PRs, or should I just include the two needed utility methods?
   
   I chose to copy in the two utility methods. However, I will follow whatever is the standard.
   
   (The two other PRs are not included in the title as they are not actually back-ported).
   
   Cast::canUpCast comes from SPARK-24586 ("Upcast should not allow casting from string to other types"). canUpCast is referenced by SPARK-28156 in CheckAnalysis. 
   
   LogicalPlan::sameOutput comes from SPARK-25691 ("Use semantic equality in AliasViewChild in order to compare attributes"). sameOutput is referenced by SPARK-28156 in CheckAnalysis.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org