[GitHub] [rocketmq-client-cpp] ifplusor commented on a change in pull request #158: merge m_futureTable and m_asyncFutureTable together.

[GitBox <gi...@apache.org>]

ifplusor commented on a change in pull request #158: merge m_futureTable and m_asyncFutureTable together.
URL: https://github.com/apache/rocketmq-client-cpp/pull/158#discussion_r303871596
 
 

 ##########
 File path: src/transport/TcpRemotingClient.cpp
 ##########
 @@ -109,8 +108,11 @@ void TcpRemotingClient::stopAllTcpTransportThread() {
   {
     std::lock_guard<std::mutex> lock(m_futureTableLock);
     for (const auto& future : m_futureTable) {
-      if (future.second)
-        future.second->releaseThreadCondition();
+      if (future.second) {
 
 Review comment:
   @jonnxu Those conditations are different side, i think this way is better to understand.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services