[incubator-superset] branch master updated: [bug] Fix CSV upload feature for DB with password (#4562)

[ma...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 31a9957  [bug] Fix CSV upload feature for DB with password (#4562)
31a9957 is described below

commit 31a995714df49e55ff69474378845fd8af605d4b
Author: Kyle Travis <ky...@gmail.com>
AuthorDate: Wed Mar 7 20:42:52 2018 -0500

    [bug] Fix CSV upload feature for DB with password (#4562)
    
    * Use sqlalchemy_uri_decrypted in create_engine calls
    
    * Update tox mysql uri
    
    * Include mysql charset=utf8 for py2.7 in tox.ini
---
 superset/db_engine_specs.py | 4 ++--
 tox.ini                     | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/superset/db_engine_specs.py b/superset/db_engine_specs.py
index 6c21206..73f8677 100644
--- a/superset/db_engine_specs.py
+++ b/superset/db_engine_specs.py
@@ -135,7 +135,7 @@ class BaseEngineSpec(object):
             'table': table,
             'df': df,
             'name': form.name.data,
-            'con': create_engine(form.con.data.sqlalchemy_uri, echo=False),
+            'con': create_engine(form.con.data.sqlalchemy_uri_decrypted, echo=False),
             'schema': form.schema.data,
             'if_exists': form.if_exists.data,
             'index': form.index.data,
@@ -875,7 +875,7 @@ class HiveEngineSpec(PrestoEngineSpec):
             TEXTFILE LOCATION '{location}'
             tblproperties ('skip.header.line.count'='1')""".format(**locals())
         logging.info(form.con.data)
-        engine = create_engine(form.con.data.sqlalchemy_uri)
+        engine = create_engine(form.con.data.sqlalchemy_uri_decrypted)
         engine.execute(sql)
 
     @classmethod
diff --git a/tox.ini b/tox.ini
index efdb8ab..8f226c6 100644
--- a/tox.ini
+++ b/tox.ini
@@ -82,7 +82,7 @@ commands =
 [testenv:py27-mysql]
 basepython = python2.7
 setenv =
-    SUPERSET__SQLALCHEMY_DATABASE_URI = mysql://root@localhost/superset?charset=utf8
+    SUPERSET__SQLALCHEMY_DATABASE_URI = mysql://mysqluser:mysqluserpassword@localhost/superset?charset=utf8
 
 [testenv:py34-mysql]
 basepython = python3.4

-- 
To stop receiving notification emails like this one, please contact
maximebeauchemin@apache.org.