You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by fpesce <gi...@git.apache.org> on 2015/06/11 19:05:31 UTC
[GitHub] trafficserver pull request: TS-3683: Add log tag for SSL Session/T...
GitHub user fpesce opened a pull request:
https://github.com/apache/trafficserver/pull/218
TS-3683: Add log tag for SSL Session/Ticket HIT and TCP connection reused
Additionally, a TSAPI function for those who used an external/plugin implementation for SSL Ticket/Session is provided.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fpesce/trafficserver TS-3683
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/218.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #218
----
commit 363a9044ab6421ef97dd3b07c1dd8b7016008d51
Author: Francois Pesce <fp...@yahoo-inc.com>
Date: 2015-06-11T17:02:57Z
TS-3683: Add a tag to log SSL Session/Ticket HIT as well as TCP connection reused
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3683: Add log tag for SSL Session/T...
Posted by fpesce <gi...@git.apache.org>.
Github user fpesce closed the pull request at:
https://github.com/apache/trafficserver/pull/218
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3683: Add log tag for SSL Session/T...
Posted by shinrich <gi...@git.apache.org>.
Github user shinrich commented on the pull request:
https://github.com/apache/trafficserver/pull/218#issuecomment-119238728
My only comment is about the limits of the client_* fields. As they stand, they only accurately track HTTP/1.x over TCP/SSL, not requests over SPDY/H2. I know that this is something additional you are working on and can be added in via an addition jira.
This pull request also needs to be rebased before it can be committed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3683: Add log tag for SSL Session/T...
Posted by fpesce <gi...@git.apache.org>.
Github user fpesce commented on the pull request:
https://github.com/apache/trafficserver/pull/218#issuecomment-120059157
Done @shinrich :smiley:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3683: Add log tag for SSL Session/T...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/218#discussion_r33428474
--- Diff: doc/admin/event-logging-formats.en.rst ---
@@ -170,6 +170,24 @@ The following list describes Traffic Server custom logging fields.
mm is the two-digit minutes value, and ss is the 2-digit seconds
value (for example, 16:01:19).
+.. _cqtr:
+
+``cqtr``
+ The TCP reused status; indicates if this request went through an
+ already established connection.
--- End diff --
Presume this is the client request? That should be explicitly mentioned.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3683: Add log tag for SSL Session/T...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/218#issuecomment-116361206
Overall I think the log tags are useful in ways aggregate statistics are not and I support adding those tags.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3683: Add log tag for SSL Session/T...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/218#discussion_r33428565
--- Diff: doc/reference/api/TSNetVConnSSLCachedHitSet.en.rst ---
@@ -0,0 +1,32 @@
+.. Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed
+ with this work for additional information regarding copyright
+ ownership. The ASF licenses this file to you under the Apache
+ License, Version 2.0 (the "License"); you may not use this file
+ except in compliance with the License. You may obtain a copy of
+ the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+ implied. See the License for the specific language governing
+ permissions and limitations under the License.
+
+
+TSNetVConnSSLCachedHitSet
+============
+
+Synopsis
+--------
+
+`#include <ts/ts.h>`
+
+.. c:function:: void TSNetVConnSSLCachedHitSet(TSVConn vc, int state)
+
+Description
+-----------
+
+ Mark an SSL Connection as reused, which means that an SSL Session Cache or an SSL Ticket have been used to prevent a full handshake for this SSL Connection.
+
--- End diff --
This API makes no sense to me. The core should know this and set the state accordingly. The better API would be to enable the plugin to control ticket use for an inbound connection but core should handle the ticket and tracking whether it was used. This is the same reason the cqtr log tag makes sense without any API to set that state.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3683: Add log tag for SSL Session/T...
Posted by shinrich <gi...@git.apache.org>.
Github user shinrich commented on the pull request:
https://github.com/apache/trafficserver/pull/218#issuecomment-119944358
Sorry I had a git log mishap pushing these changes. I missed the "This closes" comment and the changes showed up in the following for comments.
{code}
da04362227ef91b27aa7d02e9238f1ceae68689d
f3e13664ab20f60cb4bd2ffef1eb7d6a374a1698
5a4350e6067ac868e54538467ec83a9413853143
71752c741ac8b49d432dd4b13f5ea2a7f176b37e
{code}
@fpesce could you go ahead and close this pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---