You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Rakesh R (JIRA)" <ji...@apache.org> on 2012/10/10 05:10:04 UTC
[jira] [Created] (BOOKKEEPER-428) Expose command options in bookie
scripts to disable/enable auto recovery temporarily
Rakesh R created BOOKKEEPER-428:
-----------------------------------
Summary: Expose command options in bookie scripts to disable/enable auto recovery temporarily
Key: BOOKKEEPER-428
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-428
Project: Bookkeeper
Issue Type: Sub-task
Components: bookkeeper-auto-recovery
Affects Versions: 4.0.0
Reporter: Rakesh R
Assignee: Rakesh R
Fix For: 4.2.0
Administrators can invoke disble/enable autorecovery options through bookie shell.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-428) Expose command options in
bookie scripts to disable/enable auto recovery temporarily
Posted by "Vinay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473082#comment-13473082 ]
Vinay commented on BOOKKEEPER-428:
----------------------------------
Hi Rakesh,
I got that You want to implement Bookie Shell command to disable auto-recovery to be disabled.
bq. You are expecting shell command to stop auto recovery in only local node..?
If this is the case, you can directly stop the auto recovery daemon. Right?
bq.or you want to stop recovery service in all nodes by just one command..?
I agree, In this case need some changes in AutoRecoveryMain. May be we can create some znode in zookeeper and based on that we can decide whether to enable/disable the service.
> Expose command options in bookie scripts to disable/enable auto recovery temporarily
> ------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-428
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-428
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-auto-recovery
> Affects Versions: 4.0.0
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 4.2.0
>
>
> Administrators can invoke disble/enable autorecovery options through bookie shell.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-428) Expose command options in
bookie scripts to disable/enable auto recovery temporarily
Posted by "Rakesh R (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472957#comment-13472957 ]
Rakesh R commented on BOOKKEEPER-428:
-------------------------------------
The idea is to do necessary changes in AutoRecoveryMain interface to invoke ZkLedgerUnderreplicationManager.disableLedgerReplication() and ZkLedgerUnderreplicationManager.enableLedgerReplication().
Also expose command options 'enable, disable' in bookie scripts: bookkeeper, /bookkeeper-daemon.sh
> Expose command options in bookie scripts to disable/enable auto recovery temporarily
> ------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-428
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-428
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-auto-recovery
> Affects Versions: 4.0.0
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 4.2.0
>
>
> Administrators can invoke disble/enable autorecovery options through bookie shell.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-428) Expose command options in
bookie scripts to disable/enable auto recovery temporarily
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484184#comment-13484184 ]
Uma Maheswara Rao G commented on BOOKKEEPER-428:
------------------------------------------------
{code}
zk = ZkUtils.createConnectedZookeeperClient(
conf.getZkServers(), conf.getZkTimeout());
{code}
seems like, We have to re-base the patch to reflect newly modified Zkutils API (changed as part of BK-424).
> Expose command options in bookie scripts to disable/enable auto recovery temporarily
> ------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-428
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-428
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-auto-recovery
> Affects Versions: 4.0.0
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-428.patch
>
>
> Administrators can invoke disble/enable autorecovery options through bookie shell.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-428) Expose command options in
bookie scripts to disable/enable auto recovery temporarily
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487148#comment-13487148 ]
Ivan Kelly commented on BOOKKEEPER-428:
---------------------------------------
+1 for adding it to bookie shell
> Expose command options in bookie scripts to disable/enable auto recovery temporarily
> ------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-428
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-428
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-auto-recovery
> Affects Versions: 4.0.0
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-428-1.patch, BOOKKEEPER-428.patch
>
>
> Administrators can invoke disble/enable autorecovery options through bookie shell.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-428) Expose command options in
bookie scripts to disable/enable auto recovery temporarily
Posted by "Rakesh R (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484349#comment-13484349 ]
Rakesh R commented on BOOKKEEPER-428:
-------------------------------------
Thanks Uma. Latest patch addressing Uma's comment.
> Expose command options in bookie scripts to disable/enable auto recovery temporarily
> ------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-428
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-428
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-auto-recovery
> Affects Versions: 4.0.0
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-428-1.patch, BOOKKEEPER-428.patch
>
>
> Administrators can invoke disble/enable autorecovery options through bookie shell.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-428) Expose command options in bookie
scripts to disable/enable auto recovery temporarily
Posted by "Rakesh R (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rakesh R updated BOOKKEEPER-428:
--------------------------------
Attachment: BOOKKEEPER-428.patch
> Expose command options in bookie scripts to disable/enable auto recovery temporarily
> ------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-428
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-428
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-auto-recovery
> Affects Versions: 4.0.0
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-428.patch
>
>
> Administrators can invoke disble/enable autorecovery options through bookie shell.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-428) Expose command options in
bookie scripts to disable/enable auto recovery temporarily
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486646#comment-13486646 ]
Uma Maheswara Rao G commented on BOOKKEEPER-428:
------------------------------------------------
Hi Rakesh,
- Currently we missed options to document anywhere as a help message.
- Actually I feel that the shell interactions can go to BookieShell class and provide an AutoRecEndisableCmd in that.
add them to the map:
{code}
commands.put(CMD_METAFORMAT, new MetaFormatCmd());
commands.put(CMD_BOOKIEFORMAT, new BookieFormatCmd());
commands.put(CMD_RECOVER, new RecoverCmd());
commands.put(CMD_LEDGER, new LedgerCmd());
commands.put(CMD_READLOG, new ReadLogCmd());
commands.put(CMD_READJOURNAL, new ReadJournalCmd());
commands.put(CMD_LASTMARK, new LastMarkCmd());
commands.put(CMD_HELP, new HelpCmd());
{code}
- on handling #2 my first comment will be covered as part of it as it has separate HelpCmd exposed via shell.
- I also feel that, we can have a test that should check there are no further replications proceeding after disabling it. That test would be a functional test to ensure end-end.
Thanks,
Uma
> Expose command options in bookie scripts to disable/enable auto recovery temporarily
> ------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-428
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-428
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-auto-recovery
> Affects Versions: 4.0.0
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-428-1.patch, BOOKKEEPER-428.patch
>
>
> Administrators can invoke disble/enable autorecovery options through bookie shell.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-428) Expose command options in bookie
scripts to disable/enable auto recovery temporarily
Posted by "Rakesh R (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rakesh R updated BOOKKEEPER-428:
--------------------------------
Attachment: BOOKKEEPER-428-1.patch
> Expose command options in bookie scripts to disable/enable auto recovery temporarily
> ------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-428
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-428
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-auto-recovery
> Affects Versions: 4.0.0
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-428-1.patch, BOOKKEEPER-428.patch
>
>
> Administrators can invoke disble/enable autorecovery options through bookie shell.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-428) Expose command options in
bookie scripts to disable/enable auto recovery temporarily
Posted by "Rakesh R (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473950#comment-13473950 ]
Rakesh R commented on BOOKKEEPER-428:
-------------------------------------
@Vinay,
bq.I agree, In this case need some changes in AutoRecoveryMain. May be we can create some znode in zookeeper and based on that we can decide whether to enable/disable the service.
Yeah, the same is already implemented as part of BOOKKEEPER-278, please have a look at it. Here just exposing admin command to operate on.
> Expose command options in bookie scripts to disable/enable auto recovery temporarily
> ------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-428
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-428
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-auto-recovery
> Affects Versions: 4.0.0
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 4.2.0
>
>
> Administrators can invoke disble/enable autorecovery options through bookie shell.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-428) Expose command options in
bookie scripts to disable/enable auto recovery temporarily
Posted by "Rakesh R (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483492#comment-13483492 ]
Rakesh R commented on BOOKKEEPER-428:
-------------------------------------
Attached patch, which has the following command options for toggling autorecovery. Could you please review. Thanks
{code}
-d,--disable Disable auto recovery of underreplicated ledgers
-e,--enable Enable auto recovery of underreplicated ledgers
{code}
> Expose command options in bookie scripts to disable/enable auto recovery temporarily
> ------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-428
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-428
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-auto-recovery
> Affects Versions: 4.0.0
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-428.patch
>
>
> Administrators can invoke disble/enable autorecovery options through bookie shell.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira