You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ranger.apache.org by me...@apache.org on 2018/09/24 13:26:05 UTC
[2/3] ranger git commit: RANGER-2214: Do some code improvement for
the error message for KylinClient.java
RANGER-2214: Do some code improvement for the error message for KylinClient.java
Signed-off-by: 邢鹏 10209390 <xi...@zte.com.cn>
Project: http://git-wip-us.apache.org/repos/asf/ranger/repo
Commit: http://git-wip-us.apache.org/repos/asf/ranger/commit/f3d8bbe4
Tree: http://git-wip-us.apache.org/repos/asf/ranger/tree/f3d8bbe4
Diff: http://git-wip-us.apache.org/repos/asf/ranger/diff/f3d8bbe4
Branch: refs/heads/ranger-1
Commit: f3d8bbe4c131b3053fa7009704b9bf8c4d146be6
Parents: 7e19c53
Author: zhangqiang2 <zh...@zte.com.cn>
Authored: Tue Sep 11 11:28:16 2018 +0800
Committer: Mehul Parikh <me...@apache.org>
Committed: Mon Sep 24 18:55:27 2018 +0530
----------------------------------------------------------------------
.../services/kylin/client/KylinClient.java | 21 ++++++++++++++------
1 file changed, 15 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/ranger/blob/f3d8bbe4/plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinClient.java
----------------------------------------------------------------------
diff --git a/plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinClient.java b/plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinClient.java
index 9cf21aa..17e0ecb 100644
--- a/plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinClient.java
+++ b/plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinClient.java
@@ -163,12 +163,21 @@ public class KylinClient extends BaseClient {
private List<KylinProjectResponse> getKylinProjectResponse(ClientResponse response) {
List<KylinProjectResponse> projectResponses = null;
try {
- if (response != null && response.getStatus() == HttpStatus.SC_OK) {
- String jsonString = response.getEntity(String.class);
- Gson gson = new GsonBuilder().setPrettyPrinting().create();
-
- projectResponses = gson.fromJson(jsonString, new TypeToken<List<KylinProjectResponse>>() {
- }.getType());
+ if (response != null) {
+ if (response.getStatus() == HttpStatus.SC_OK) {
+ String jsonString = response.getEntity(String.class);
+ Gson gson = new GsonBuilder().setPrettyPrinting().create();
+
+ projectResponses = gson.fromJson(jsonString, new TypeToken<List<KylinProjectResponse>>() {
+ }.getType());
+ } else {
+ String msgDesc = "Unable to get a valid response for " + "expected mime type : [" + EXPECTED_MIME_TYPE
+ + "], kylinUrl: " + kylinUrl + " - got http response code " + response.getStatus();
+ LOG.error(msgDesc);
+ HadoopException hdpException = new HadoopException(msgDesc);
+ hdpException.generateResponseDataMap(false, msgDesc, msgDesc + ERROR_MESSAGE, null, null);
+ throw hdpException;
+ }
} else {
String msgDesc = "Unable to get a valid response for " + "expected mime type : [" + EXPECTED_MIME_TYPE
+ "], kylinUrl: " + kylinUrl + " - got null response.";