You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/02/23 02:12:50 UTC
[GitHub] [iceberg] happyprg opened a new pull request #4203: fix: change invalid typo commited to committed
happyprg opened a new pull request #4203:
URL: https://github.com/apache/iceberg/pull/4203
fix: change invalid typo `commited` to `committed`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] happyprg commented on a change in pull request #4203: fix: change invalid typo commited to committed
Posted by GitBox <gi...@apache.org>.
happyprg commented on a change in pull request #4203:
URL: https://github.com/apache/iceberg/pull/4203#discussion_r812511839
##########
File path: python_legacy/iceberg/core/base_transaction.py
##########
@@ -60,13 +60,13 @@ def __init__(self, ops, start):
def table(self):
return self.transaction_table
- def check_last_operation_commited(self, operation):
+ def check_last_operation_committed(self, operation):
Review comment:
@kbendick
> may I suggest to add a note above each saying that they are misspelled?
Yes
> That way, if anybody goes to copy this code to the new python library / API, they will update it.
If then, do I close this PR? and you are going to comment about it on another PR?
I don't know How can I commenting it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] happyprg commented on a change in pull request #4203: fix: change invalid typo commited to committed
Posted by GitBox <gi...@apache.org>.
happyprg commented on a change in pull request #4203:
URL: https://github.com/apache/iceberg/pull/4203#discussion_r812517279
##########
File path: python_legacy/iceberg/core/base_transaction.py
##########
@@ -60,13 +60,13 @@ def __init__(self, ops, start):
def table(self):
return self.transaction_table
- def check_last_operation_commited(self, operation):
+ def check_last_operation_committed(self, operation):
Review comment:
> You can just add a comment above each, in this PR if you'd like.
>
> Like
>
> ```python
> # NOTE: function name has typo in the word `comitted`. Kept for backwards compatability in legacy python API.
> def check_last_operation_commited(self, operation):
> pass
> ```
>
> Then, if somebody goes to copy this code to the new python API, that note will come up during code review.
@kbendick
Thank you for teaching me good points I applied your suggestion. I really appreciate that :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] happyprg commented on pull request #4203: chore: commenting invalid typo `commited` in base_transaction.py and fix invalid typos in test_cases
Posted by GitBox <gi...@apache.org>.
happyprg commented on pull request #4203:
URL: https://github.com/apache/iceberg/pull/4203#issuecomment-1053837420
PTAL @happyprg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] happyprg edited a comment on pull request #4203: chore: commenting invalid typo `commited` in base_transaction.py and fix invalid typos in test_cases
Posted by GitBox <gi...@apache.org>.
happyprg edited a comment on pull request #4203:
URL: https://github.com/apache/iceberg/pull/4203#issuecomment-1053837420
PTAL @kbendick
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] happyprg commented on a change in pull request #4203: fix: change invalid typo commited to committed
Posted by GitBox <gi...@apache.org>.
happyprg commented on a change in pull request #4203:
URL: https://github.com/apache/iceberg/pull/4203#discussion_r812517279
##########
File path: python_legacy/iceberg/core/base_transaction.py
##########
@@ -60,13 +60,13 @@ def __init__(self, ops, start):
def table(self):
return self.transaction_table
- def check_last_operation_commited(self, operation):
+ def check_last_operation_committed(self, operation):
Review comment:
> You can just add a comment above each, in this PR if you'd like.
>
> Like
>
> ```python
> # NOTE: function name has typo in the word `comitted`. Kept for backwards compatability in legacy python API.
> def check_last_operation_commited(self, operation):
> pass
> ```
>
> Then, if somebody goes to copy this code to the new python API, that note will come up during code review.
@kbendick
Thank you for teaching me good points I applied your suggestion.
I am reading `python_legacy` module for understanding `Apache Iceberg` .
I will open another PR if there are invalid typos like this following the convention which you taught me above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] happyprg commented on a change in pull request #4203: chore: commenting invalid typo `commited` in base_transaction.py and fix invalid typos in test_cases
Posted by GitBox <gi...@apache.org>.
happyprg commented on a change in pull request #4203:
URL: https://github.com/apache/iceberg/pull/4203#discussion_r812616419
##########
File path: python_legacy/iceberg/core/base_transaction.py
##########
@@ -60,6 +60,7 @@ def __init__(self, ops, start):
def table(self):
return self.transaction_table
+ # NOTE: function name has typo in the word `comitted`. Kept for backwards compatability in legacy python API.
def check_last_operation_commited(self, operation):
Review comment:
> Wasn't there a second typo? I would include the comment with both, s
@kbendick
What's mean exactly? (Sorry My native language is not English. 🙂 )
I copied and pasted your comment.
Do I have to make changes to this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a change in pull request #4203: chore: commenting invalid typo `commited` in base_transaction.py and fix invalid typos in test_cases
Posted by GitBox <gi...@apache.org>.
kbendick commented on a change in pull request #4203:
URL: https://github.com/apache/iceberg/pull/4203#discussion_r814318089
##########
File path: python_legacy/iceberg/core/base_transaction.py
##########
@@ -60,6 +60,7 @@ def __init__(self, ops, start):
def table(self):
return self.transaction_table
+ # NOTE: function name has typo in the word `comitted`. Kept for backwards compatability in legacy python API.
def check_last_operation_commited(self, operation):
Review comment:
Originally, when you updated the typo, I thought there was two cases of it.
If that's true, then I would put the comment above both functions that are misspelled, so that if somebody goes to copy them they'll update both (and not only one).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] happyprg commented on a change in pull request #4203: fix: change invalid typo commited to committed
Posted by GitBox <gi...@apache.org>.
happyprg commented on a change in pull request #4203:
URL: https://github.com/apache/iceberg/pull/4203#discussion_r812511839
##########
File path: python_legacy/iceberg/core/base_transaction.py
##########
@@ -60,13 +60,13 @@ def __init__(self, ops, start):
def table(self):
return self.transaction_table
- def check_last_operation_commited(self, operation):
+ def check_last_operation_committed(self, operation):
Review comment:
@kbendick
> may I suggest to add a note above each saying that they are misspelled?
Yes
> That way, if anybody goes to copy this code to the new python library / API, they will update it.
If then, do I close this PR? and you are going to comment about it on another PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] happyprg commented on pull request #4203: fix: change invalid typo commited to committed
Posted by GitBox <gi...@apache.org>.
happyprg commented on pull request #4203:
URL: https://github.com/apache/iceberg/pull/4203#issuecomment-1048400398
PTAL :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] happyprg commented on a change in pull request #4203: fix: change invalid typo commited to committed
Posted by GitBox <gi...@apache.org>.
happyprg commented on a change in pull request #4203:
URL: https://github.com/apache/iceberg/pull/4203#discussion_r812511839
##########
File path: python_legacy/iceberg/core/base_transaction.py
##########
@@ -60,13 +60,13 @@ def __init__(self, ops, start):
def table(self):
return self.transaction_table
- def check_last_operation_commited(self, operation):
+ def check_last_operation_committed(self, operation):
Review comment:
@kbendick
> may I suggest to add a note above each saying that they are misspelled?
Yes
> may I suggest to add a note above each saying that they are misspelled?
> That way, if anybody goes to copy this code to the new python library / API, they will update it.
If then, do I close this PR? and you are going to comment about it on another PR?
I don't know How can I commenting it :)
Would you please let me know how can I leave it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a change in pull request #4203: fix: change invalid typo commited to committed
Posted by GitBox <gi...@apache.org>.
kbendick commented on a change in pull request #4203:
URL: https://github.com/apache/iceberg/pull/4203#discussion_r812515452
##########
File path: python_legacy/iceberg/core/base_transaction.py
##########
@@ -60,13 +60,13 @@ def __init__(self, ops, start):
def table(self):
return self.transaction_table
- def check_last_operation_commited(self, operation):
+ def check_last_operation_committed(self, operation):
Review comment:
You can just add a comment above each, in this PR if you'd like.
Like
```python
# NOTE: function name has typo in the word `comitted`. Kept for backwards compatability in legacy python API.
def check_last_operation_commited(self, operation):
pass
```
Then, if somebody goes to copy this code to the new python API, that note will come up during code review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] happyprg commented on a change in pull request #4203: fix: change invalid typo commited to committed
Posted by GitBox <gi...@apache.org>.
happyprg commented on a change in pull request #4203:
URL: https://github.com/apache/iceberg/pull/4203#discussion_r812517279
##########
File path: python_legacy/iceberg/core/base_transaction.py
##########
@@ -60,13 +60,13 @@ def __init__(self, ops, start):
def table(self):
return self.transaction_table
- def check_last_operation_commited(self, operation):
+ def check_last_operation_committed(self, operation):
Review comment:
> You can just add a comment above each, in this PR if you'd like.
>
> Like
>
> ```python
> # NOTE: function name has typo in the word `comitted`. Kept for backwards compatability in legacy python API.
> def check_last_operation_commited(self, operation):
> pass
> ```
>
> Then, if somebody goes to copy this code to the new python API, that note will come up during code review.
@kbendick
Thank you for teaching me good points I applied your suggestion.
I am reading `python_legacy` module for understanding `Apache Iceberg` .
I will open another PR if there are invalid typos like this following the convention which you taught me above.
I really appreciate that :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] happyprg commented on a change in pull request #4203: fix: change invalid typo commited to committed
Posted by GitBox <gi...@apache.org>.
happyprg commented on a change in pull request #4203:
URL: https://github.com/apache/iceberg/pull/4203#discussion_r812511839
##########
File path: python_legacy/iceberg/core/base_transaction.py
##########
@@ -60,13 +60,13 @@ def __init__(self, ops, start):
def table(self):
return self.transaction_table
- def check_last_operation_commited(self, operation):
+ def check_last_operation_committed(self, operation):
Review comment:
@kbendick
> may I suggest to add a note above each saying that they are misspelled?
Yes
> That way, if anybody goes to copy this code to the new python library / API, they will update it.
If then, do I close this PR, and you are going to comment about it on another PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a change in pull request #4203: chore: commenting invalid typo `commited` in base_transaction.py and fix invalid typos in test_cases
Posted by GitBox <gi...@apache.org>.
kbendick commented on a change in pull request #4203:
URL: https://github.com/apache/iceberg/pull/4203#discussion_r812589961
##########
File path: python_legacy/iceberg/core/base_transaction.py
##########
@@ -60,6 +60,7 @@ def __init__(self, ops, start):
def table(self):
return self.transaction_table
+ # NOTE: function name has typo in the word `comitted`. Kept for backwards compatability in legacy python API.
def check_last_operation_commited(self, operation):
Review comment:
Wasn't there a second typo? I would include the comment with both, since these sorts of changes in less-strictly typed languages are harder to fix once they get in (assuming that this function is part of a public API, which we can't really control as much in Python).
People will likely pull some code from `python_legacy` while maaking the new API, and definitely in the new python library we don't want the method to be misspelled 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] happyprg commented on a change in pull request #4203: fix: change invalid typo commited to committed
Posted by GitBox <gi...@apache.org>.
happyprg commented on a change in pull request #4203:
URL: https://github.com/apache/iceberg/pull/4203#discussion_r812517279
##########
File path: python_legacy/iceberg/core/base_transaction.py
##########
@@ -60,13 +60,13 @@ def __init__(self, ops, start):
def table(self):
return self.transaction_table
- def check_last_operation_commited(self, operation):
+ def check_last_operation_committed(self, operation):
Review comment:
> You can just add a comment above each, in this PR if you'd like.
>
> Like
>
> ```python
> # NOTE: function name has typo in the word `comitted`. Kept for backwards compatability in legacy python API.
> def check_last_operation_commited(self, operation):
> pass
> ```
>
> Then, if somebody goes to copy this code to the new python API, that note will come up during code review.
@kbendick
Thank you for teaching me good points I applied your suggestion. I really appreciate that :)
I just rollback to before and left comment which you taught me above https://github.com/apache/iceberg/pull/4203/commits/30b1c6f052e9744b492862d9a5dbe8c13f0b3fcc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] happyprg commented on a change in pull request #4203: chore: commenting invalid typo `commited` in base_transaction.py and fix invalid typos in test_cases
Posted by GitBox <gi...@apache.org>.
happyprg commented on a change in pull request #4203:
URL: https://github.com/apache/iceberg/pull/4203#discussion_r815554540
##########
File path: python_legacy/iceberg/core/base_transaction.py
##########
@@ -60,6 +60,7 @@ def __init__(self, ops, start):
def table(self):
return self.transaction_table
+ # NOTE: function name has typo in the word `comitted`. Kept for backwards compatability in legacy python API.
def check_last_operation_commited(self, operation):
Review comment:
@kbendick Thank you for giving me a reply.
I already fixed all which I know :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a change in pull request #4203: chore: commenting invalid typo `commited` in base_transaction.py and fix invalid typos in test_cases
Posted by GitBox <gi...@apache.org>.
kbendick commented on a change in pull request #4203:
URL: https://github.com/apache/iceberg/pull/4203#discussion_r812590293
##########
File path: python_legacy/tests/api/expressions/test_predicate_binding.py
##########
@@ -64,7 +64,7 @@ def test_comparison_predicate_binding(op, assert_and_unwrap):
assert op == bound.op
-def test_literal_converison(op, assert_and_unwrap):
+def test_literal_conversion(op, assert_and_unwrap):
Review comment:
Good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a change in pull request #4203: fix: change invalid typo commited to committed
Posted by GitBox <gi...@apache.org>.
kbendick commented on a change in pull request #4203:
URL: https://github.com/apache/iceberg/pull/4203#discussion_r812510531
##########
File path: python_legacy/iceberg/core/base_transaction.py
##########
@@ -60,13 +60,13 @@ def __init__(self, ops, start):
def table(self):
return self.transaction_table
- def check_last_operation_commited(self, operation):
+ def check_last_operation_committed(self, operation):
Review comment:
So while this is a typo, it's also a breaking change to the API.
Since we might use some of this code in the new `python` library, may I suggest to add a note above each saying that they are misspelled? That way, if anybody goes to copy this code to the new `python` library / API, they will update it.
But I don't think it's a good idea to introduce this breaking change, as people likely rely on the (misspelled) name at present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] happyprg commented on a change in pull request #4203: fix: change invalid typo commited to committed
Posted by GitBox <gi...@apache.org>.
happyprg commented on a change in pull request #4203:
URL: https://github.com/apache/iceberg/pull/4203#discussion_r812511839
##########
File path: python_legacy/iceberg/core/base_transaction.py
##########
@@ -60,13 +60,13 @@ def __init__(self, ops, start):
def table(self):
return self.transaction_table
- def check_last_operation_commited(self, operation):
+ def check_last_operation_committed(self, operation):
Review comment:
@kbendick
> may I suggest to add a note above each saying that they are misspelled?
Yes
> That way, if anybody goes to copy this code to the new python library / API, they will update it.
If then, do I close this PR? and you are going to comment about it on another PR?
I don't know How can I commenting it :)
Would you please let me know how can I leave it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] happyprg commented on a change in pull request #4203: chore: commenting invalid typo `commited` in base_transaction.py and fix invalid typos in test_cases
Posted by GitBox <gi...@apache.org>.
happyprg commented on a change in pull request #4203:
URL: https://github.com/apache/iceberg/pull/4203#discussion_r812616419
##########
File path: python_legacy/iceberg/core/base_transaction.py
##########
@@ -60,6 +60,7 @@ def __init__(self, ops, start):
def table(self):
return self.transaction_table
+ # NOTE: function name has typo in the word `comitted`. Kept for backwards compatability in legacy python API.
def check_last_operation_commited(self, operation):
Review comment:
> Wasn't there a second typo? I would include the comment with both, s
@kbendick
What's mean exactly? (Sorry My native language is not English. 🙂 )
Do I have to make changes to this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] happyprg commented on a change in pull request #4203: chore: commenting invalid typo `commited` in base_transaction.py and fix invalid typos in test_cases
Posted by GitBox <gi...@apache.org>.
happyprg commented on a change in pull request #4203:
URL: https://github.com/apache/iceberg/pull/4203#discussion_r812616419
##########
File path: python_legacy/iceberg/core/base_transaction.py
##########
@@ -60,6 +60,7 @@ def __init__(self, ops, start):
def table(self):
return self.transaction_table
+ # NOTE: function name has typo in the word `comitted`. Kept for backwards compatability in legacy python API.
def check_last_operation_commited(self, operation):
Review comment:
> Wasn't there a second typo? I would include the comment with both, s
@kbendick
What's mean exactly? (Sorry My native language is not English.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org