You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/16 06:56:27 UTC
[GitHub] [skywalking-swck] hanahmily opened a new pull request #16: Add unit test case for operator
hanahmily opened a new pull request #16:
URL: https://github.com/apache/skywalking-swck/pull/16
Signed-off-by: Gao Hongtao <ha...@gmail.com>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] hanahmily commented on a change in pull request #16: Add unit test case for operator
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #16:
URL: https://github.com/apache/skywalking-swck/pull/16#discussion_r544831481
##########
File path: .github/workflows/go.yml
##########
@@ -37,17 +55,30 @@ jobs:
uses: actions/checkout@v2
- name: Update dependencies
run: GOPROXY=https://proxy.golang.org go mod download
- - name: Lint
- run: make lint
- - name: Check
- run: make check
- name: Build
run: make
- name: Build docker image
run: make docker-build
+ unit-tests:
+ name: Unit tests
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Install Go
+ uses: actions/setup-go@v2
+ with:
+ go-version: 1.14
+ id: go
+ - name: Check out code into the Go module directory
+ uses: actions/checkout@v2
+ - name: Update dependencies
+ run: GOPROXY=https://proxy.golang.org go mod download
+ - name: "install kubebuilder"
+ run: ./hack/install-kubebuilder.sh
+ - name: tests
+ run: make test
checks:
- name: build
Review comment:
done. change the name to `ci` that is more sense to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] hanahmily merged pull request #16: Add unit test case for operator
Posted by GitBox <gi...@apache.org>.
hanahmily merged pull request #16:
URL: https://github.com/apache/skywalking-swck/pull/16
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] kezhenxu94 commented on a change in pull request #16: Add unit test case for operator
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #16:
URL: https://github.com/apache/skywalking-swck/pull/16#discussion_r544796823
##########
File path: .github/workflows/go.yml
##########
@@ -37,17 +55,30 @@ jobs:
uses: actions/checkout@v2
- name: Update dependencies
run: GOPROXY=https://proxy.golang.org go mod download
- - name: Lint
- run: make lint
- - name: Check
- run: make check
- name: Build
run: make
- name: Build docker image
run: make docker-build
+ unit-tests:
+ name: Unit tests
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Install Go
+ uses: actions/setup-go@v2
+ with:
+ go-version: 1.14
+ id: go
+ - name: Check out code into the Go module directory
+ uses: actions/checkout@v2
+ - name: Update dependencies
+ run: GOPROXY=https://proxy.golang.org go mod download
+ - name: "install kubebuilder"
+ run: ./hack/install-kubebuilder.sh
+ - name: tests
+ run: make test
checks:
- name: build
Review comment:
this job is to make the required check status pass, if you want to change the name, may need to also change the one in `.asf.yaml`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] kezhenxu94 commented on a change in pull request #16: Add unit test case for operator
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #16:
URL: https://github.com/apache/skywalking-swck/pull/16#discussion_r544856417
##########
File path: .github/workflows/go.yml
##########
@@ -37,17 +55,30 @@ jobs:
uses: actions/checkout@v2
- name: Update dependencies
run: GOPROXY=https://proxy.golang.org go mod download
- - name: Lint
- run: make lint
- - name: Check
- run: make check
- name: Build
run: make
- name: Build docker image
run: make docker-build
+ unit-tests:
+ name: Unit tests
+ runs-on: ubuntu-20.04
+ steps:
+ - name: Install Go
+ uses: actions/setup-go@v2
+ with:
+ go-version: 1.14
+ id: go
+ - name: Check out code into the Go module directory
+ uses: actions/checkout@v2
+ - name: Update dependencies
+ run: GOPROXY=https://proxy.golang.org go mod download
+ - name: "install kubebuilder"
+ run: ./hack/install-kubebuilder.sh
+ - name: tests
+ run: make test
checks:
- name: build
Review comment:
The `build` job needs be kept for now to make checks status pass, after this gets merged (`.asf` takes effect`), we can remove it then
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org