You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "jcesarmobile (via GitHub)" <gi...@apache.org> on 2023/04/14 23:14:00 UTC

[GitHub] [cordova-ios] jcesarmobile opened a new pull request, #1309: feat!: Use single 1024x1024 icon

jcesarmobile opened a new pull request, #1309:
URL: https://github.com/apache/cordova-ios/pull/1309

   Xcode 14 allows to use a single 1024x1024 icon instead of having all the icon sizes.
   
   It's breaking because it requires Xcode 14, but since Xcode 14.1 is going to be required for app store submissions starting the 25 of April, I think we are good.
   
   Removed the icon sizes link because it was broken


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-ios] jcesarmobile commented on pull request #1309: feat!: Use single 1024x1024 icon

Posted by "jcesarmobile (via GitHub)" <gi...@apache.org>.
jcesarmobile commented on PR #1309:
URL: https://github.com/apache/cordova-ios/pull/1309#issuecomment-1509610513

   If using single icon, Xcode only allows a single icon, doesn’t allow to add a different icon notifications. 
   It allows a different icon for watchOS, but at the moment it was using the same as for iOS 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-ios] breautek commented on pull request #1309: feat!: Use single 1024x1024 icon

Posted by "breautek (via GitHub)" <gi...@apache.org>.
breautek commented on PR #1309:
URL: https://github.com/apache/cordova-ios/pull/1309#issuecomment-1546631369

   FWIW, we've gone back in our apps and just supplied the icons that were missing (so that we aren't relying on a feature that may not even make it into release).
   
   This appears to cover all current icons, at least for the iPhone models.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-ios] breautek commented on pull request #1309: feat!: Use single 1024x1024 icon

Posted by "breautek (via GitHub)" <gi...@apache.org>.
breautek commented on PR #1309:
URL: https://github.com/apache/cordova-ios/pull/1309#issuecomment-1532985511

   It's also breaking in the sense it requires iOS 12+
   
   
   ![Screenshot 2023-05-03 at 9 48 57 AM](https://user-images.githubusercontent.com/11200662/235922549-3101c7c1-3271-47fa-828e-62529e2a366d.png)
   
   So I think we also need to bump CordovaLib min target to iOS 12, which doesn't have to be part of this PR, but it will need to be  set for this feature.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-ios] dpogue commented on pull request #1309: feat!: Use single 1024x1024 icon

Posted by "dpogue (via GitHub)" <gi...@apache.org>.
dpogue commented on PR #1309:
URL: https://github.com/apache/cordova-ios/pull/1309#issuecomment-1509621734

   Note: Closes #1019


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-ios] dpogue commented on pull request #1309: feat!: Use single 1024x1024 icon

Posted by "dpogue (via GitHub)" <gi...@apache.org>.
dpogue commented on PR #1309:
URL: https://github.com/apache/cordova-ios/pull/1309#issuecomment-1509610665

   Ahh okay


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-ios] erisu commented on pull request #1309: feat!: Use single 1024x1024 icon

Posted by "erisu (via GitHub)" <gi...@apache.org>.
erisu commented on PR #1309:
URL: https://github.com/apache/cordova-ios/pull/1309#issuecomment-1578880976

   I believe it was decided to staying on iOS 11, so I think this PR can be closed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-ios] codecov-commenter commented on pull request #1309: feat!: Use single 1024x1024 icon

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1309:
URL: https://github.com/apache/cordova-ios/pull/1309#issuecomment-1509388005

   ## [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1309?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1309](https://codecov.io/gh/apache/cordova-ios/pull/1309?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1b6a41b) into [master](https://codecov.io/gh/apache/cordova-ios/commit/3d6c71ab0f16c2772e827f1d258d5f028359d58a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3d6c71a) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #1309   +/-   ##
   =======================================
     Coverage   78.48%   78.48%           
   =======================================
     Files          15       15           
     Lines        1780     1780           
   =======================================
     Hits         1397     1397           
     Misses        383      383           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/1309?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/1309?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL3ByZXBhcmUuanM=) | `85.02% <ø> (ø)` | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-ios] jcesarmobile closed pull request #1309: feat!: Use single 1024x1024 icon

Posted by "jcesarmobile (via GitHub)" <gi...@apache.org>.
jcesarmobile closed pull request #1309: feat!: Use single 1024x1024 icon
URL: https://github.com/apache/cordova-ios/pull/1309


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-ios] dpogue commented on pull request #1309: feat!: Use single 1024x1024 icon

Posted by "dpogue (via GitHub)" <gi...@apache.org>.
dpogue commented on PR #1309:
URL: https://github.com/apache/cordova-ios/pull/1309#issuecomment-1509386915

   We should make sure this works properly if someone just puts `<icon src="res/ios/icon.png" />` in their config.xml (with no sizes specified).
   
   There's a part of me that thinks it would be good to have some support for customizing the notification and watch icons, but that would involve dynamically adding them to the .xcassets Contents.json only if they were specified, which feels like it would be error-prone if people are mixing manual changes and automatic ones 😞 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org