You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@pivot.apache.org by Tom Eyckmans <te...@gmail.com> on 2013/04/08 18:03:46 UTC
Guice integration for apache-pivot
Hi,
Just wanted to let you known I've created a Guice extension/integration for
apache-pivot (if you can call it that it's just one class :P). I didn't
find it so thought I'd share it with you.
You can find it here: https://bitbucket.org/teyckmans/guicy-apache-pivot/
overview
I've created a GuicyBXMLSerializer that extends the BXMLSerializer class.
It overrides the newTypedObject method to have Guice create new classes and
the newIncludeSerializer method to make sure that included BXML files also
use the GuicyBXMLSerializer.
So to use it you only have to use the GuicyBXMLSerializer instead of the
normal BXMLSerializer to have Guice wire your GUI classes up.
Kind regards,
Tom Eyckmans
Re: Guice integration for apache-pivot
Posted by Sandro Martini <sa...@gmail.com>.
Hi Tom,
assigned Committer rights for pivot-contrib, so you can now add it as a new
project under trunk.
Have a good commit :-) . If you need some help/info, ask to us, don't worry.
After the commit tell to us so we can look at it (and maybe help to align
to other subprojects here) ...
Be free to add even a pre-packages jar under download section, and maybe
even a wiki page with some info on its usage, if/when you have some time.
Bye,
Sandro
2013/4/22 Tom Eyckmans <te...@gmail.com>
> Hi Sandro,
>
> I've changed the package and added the copyright header to the sources.
> I've got a Gradle build for this project so it's easiest to have the
> dependencies come from maven central so when or if this jar is published
> the external dependencies are ok in the pom.
>
> Created https://issues.apache.org/jira/browse/PIVOT-904 for this.
>
> Kr,
>
> Tom
>
>
> On 22 April 2013 17:27, Tom Eyckmans <te...@gmail.com> wrote:
>
>> Hi Sandro,
>>
>> My google account name is teyckmans@gmail.com, I'll make the needed
>> changes.
>>
>> Kr,
>>
>> Tom
>>
>>
>> On 19 April 2013 14:46, Sandro Martini <sa...@gmail.com> wrote:
>>
>>> Hi Tom,
>>> I think that we can proceed in two steps:
>>>
>>> 1 - send me your google account name (if different from current email)
>>> so I can grant to you committer rights into pivot-contrib, then create
>>> there (under trunk) a Java project with your classes (and maybe all related
>>> libraries, etc).
>>> Remember only to change your package to something like
>>> pivot_contrib.<your-project-name>, and if possible, attach the license
>>> header in any source file (like in Pivot). Of course I can help you to
>>> review the project and sources one time published there (if it's ok for
>>> you) ... remember only to checkout the trunk in https or you will not be
>>> able to commit :-) :
>>> https://code.google.com/a/apache-extras.org/p/pivot-contrib/
>>> Put any doc/wiki as you want there ...
>>> Note that for dependencies on Pivot libraries I suggest to depend on the
>>> project pivot2-dependencies from its trunk (
>>> https://code.google.com/a/apache-extras.org/p/pivot-common/ ) and
>>> download in the same workspace, or use maven (but at the moment Pivot jars
>>> for 2.0.3 aren't published, until we have a successful vote for that
>>> release). But I can do this "cleanup" later.
>>> Last, I suggest a build script in root on your project (ant or maven, or
>>> maybe even gradle or sbt) to generate a jar for your project.
>>>
>>> 2 (for mid/long-term) - you can add a new JIRA issue (
>>> https://issues.apache.org/jira/browse/PIVOT ) targeted for 2.1 release
>>> and attach there the code, or link to existing code under pivot-contrib.
>>> Don't worry on details, I can help/fix things there after you post/write
>>> something there.
>>> After this we can discuss if/how/when to integrate in core Pivot, and
>>> see what others think. There is always the problem of external dependencies
>>> etc, but we have more time for all this stuff.
>>>
>>> Tell me if it's ok, and of course if you need info/help ask to us.
>>> Thanks for now.
>>>
>>> Bye,
>>> Sandro
>>>
>>>
>>>
>>> 2013/4/18 teyckmans <te...@gmail.com>
>>>
>>>> Hi Sandro,
>>>>
>>>> I'm happy to go with the option that you think is best. What is your
>>>> prefference?
>>>>
>>>> Kind regards,
>>>>
>>>> Tom
>>>>
>>>>
>>>>
>>>> --
>>>> View this message in context:
>>>> http://apache-pivot-users.399431.n3.nabble.com/Guice-integration-for-apache-pivot-tp4022557p4022572.html
>>>> Sent from the Apache Pivot - Users mailing list archive at Nabble.com.
>>>>
>>>
>>>
>>
>
Re: Guice integration for apache-pivot
Posted by Tom Eyckmans <te...@gmail.com>.
Hi Sandro,
I've changed the package and added the copyright header to the sources.
I've got a Gradle build for this project so it's easiest to have the
dependencies come from maven central so when or if this jar is published
the external dependencies are ok in the pom.
Created https://issues.apache.org/jira/browse/PIVOT-904 for this.
Kr,
Tom
On 22 April 2013 17:27, Tom Eyckmans <te...@gmail.com> wrote:
> Hi Sandro,
>
> My google account name is teyckmans@gmail.com, I'll make the needed
> changes.
>
> Kr,
>
> Tom
>
>
> On 19 April 2013 14:46, Sandro Martini <sa...@gmail.com> wrote:
>
>> Hi Tom,
>> I think that we can proceed in two steps:
>>
>> 1 - send me your google account name (if different from current email) so
>> I can grant to you committer rights into pivot-contrib, then create there
>> (under trunk) a Java project with your classes (and maybe all related
>> libraries, etc).
>> Remember only to change your package to something like
>> pivot_contrib.<your-project-name>, and if possible, attach the license
>> header in any source file (like in Pivot). Of course I can help you to
>> review the project and sources one time published there (if it's ok for
>> you) ... remember only to checkout the trunk in https or you will not be
>> able to commit :-) :
>> https://code.google.com/a/apache-extras.org/p/pivot-contrib/
>> Put any doc/wiki as you want there ...
>> Note that for dependencies on Pivot libraries I suggest to depend on the
>> project pivot2-dependencies from its trunk (
>> https://code.google.com/a/apache-extras.org/p/pivot-common/ ) and
>> download in the same workspace, or use maven (but at the moment Pivot jars
>> for 2.0.3 aren't published, until we have a successful vote for that
>> release). But I can do this "cleanup" later.
>> Last, I suggest a build script in root on your project (ant or maven, or
>> maybe even gradle or sbt) to generate a jar for your project.
>>
>> 2 (for mid/long-term) - you can add a new JIRA issue (
>> https://issues.apache.org/jira/browse/PIVOT ) targeted for 2.1 release
>> and attach there the code, or link to existing code under pivot-contrib.
>> Don't worry on details, I can help/fix things there after you post/write
>> something there.
>> After this we can discuss if/how/when to integrate in core Pivot, and see
>> what others think. There is always the problem of external dependencies
>> etc, but we have more time for all this stuff.
>>
>> Tell me if it's ok, and of course if you need info/help ask to us.
>> Thanks for now.
>>
>> Bye,
>> Sandro
>>
>>
>>
>> 2013/4/18 teyckmans <te...@gmail.com>
>>
>>> Hi Sandro,
>>>
>>> I'm happy to go with the option that you think is best. What is your
>>> prefference?
>>>
>>> Kind regards,
>>>
>>> Tom
>>>
>>>
>>>
>>> --
>>> View this message in context:
>>> http://apache-pivot-users.399431.n3.nabble.com/Guice-integration-for-apache-pivot-tp4022557p4022572.html
>>> Sent from the Apache Pivot - Users mailing list archive at Nabble.com.
>>>
>>
>>
>
Re: Guice integration for apache-pivot
Posted by Tom Eyckmans <te...@gmail.com>.
Hi Sandro,
My google account name is teyckmans@gmail.com, I'll make the needed changes.
Kr,
Tom
On 19 April 2013 14:46, Sandro Martini <sa...@gmail.com> wrote:
> Hi Tom,
> I think that we can proceed in two steps:
>
> 1 - send me your google account name (if different from current email) so
> I can grant to you committer rights into pivot-contrib, then create there
> (under trunk) a Java project with your classes (and maybe all related
> libraries, etc).
> Remember only to change your package to something like
> pivot_contrib.<your-project-name>, and if possible, attach the license
> header in any source file (like in Pivot). Of course I can help you to
> review the project and sources one time published there (if it's ok for
> you) ... remember only to checkout the trunk in https or you will not be
> able to commit :-) :
> https://code.google.com/a/apache-extras.org/p/pivot-contrib/
> Put any doc/wiki as you want there ...
> Note that for dependencies on Pivot libraries I suggest to depend on the
> project pivot2-dependencies from its trunk (
> https://code.google.com/a/apache-extras.org/p/pivot-common/ ) and
> download in the same workspace, or use maven (but at the moment Pivot jars
> for 2.0.3 aren't published, until we have a successful vote for that
> release). But I can do this "cleanup" later.
> Last, I suggest a build script in root on your project (ant or maven, or
> maybe even gradle or sbt) to generate a jar for your project.
>
> 2 (for mid/long-term) - you can add a new JIRA issue (
> https://issues.apache.org/jira/browse/PIVOT ) targeted for 2.1 release
> and attach there the code, or link to existing code under pivot-contrib.
> Don't worry on details, I can help/fix things there after you post/write
> something there.
> After this we can discuss if/how/when to integrate in core Pivot, and see
> what others think. There is always the problem of external dependencies
> etc, but we have more time for all this stuff.
>
> Tell me if it's ok, and of course if you need info/help ask to us.
> Thanks for now.
>
> Bye,
> Sandro
>
>
>
> 2013/4/18 teyckmans <te...@gmail.com>
>
>> Hi Sandro,
>>
>> I'm happy to go with the option that you think is best. What is your
>> prefference?
>>
>> Kind regards,
>>
>> Tom
>>
>>
>>
>> --
>> View this message in context:
>> http://apache-pivot-users.399431.n3.nabble.com/Guice-integration-for-apache-pivot-tp4022557p4022572.html
>> Sent from the Apache Pivot - Users mailing list archive at Nabble.com.
>>
>
>
Re: Guice integration for apache-pivot
Posted by Sandro Martini <sa...@gmail.com>.
Hi Tom,
I think that we can proceed in two steps:
1 - send me your google account name (if different from current email) so I
can grant to you committer rights into pivot-contrib, then create there
(under trunk) a Java project with your classes (and maybe all related
libraries, etc).
Remember only to change your package to something like
pivot_contrib.<your-project-name>, and if possible, attach the license
header in any source file (like in Pivot). Of course I can help you to
review the project and sources one time published there (if it's ok for
you) ... remember only to checkout the trunk in https or you will not be
able to commit :-) :
https://code.google.com/a/apache-extras.org/p/pivot-contrib/
Put any doc/wiki as you want there ...
Note that for dependencies on Pivot libraries I suggest to depend on the
project pivot2-dependencies from its trunk (
https://code.google.com/a/apache-extras.org/p/pivot-common/ ) and download
in the same workspace, or use maven (but at the moment Pivot jars for 2.0.3
aren't published, until we have a successful vote for that release). But I
can do this "cleanup" later.
Last, I suggest a build script in root on your project (ant or maven, or
maybe even gradle or sbt) to generate a jar for your project.
2 (for mid/long-term) - you can add a new JIRA issue (
https://issues.apache.org/jira/browse/PIVOT ) targeted for 2.1 release and
attach there the code, or link to existing code under pivot-contrib. Don't
worry on details, I can help/fix things there after you post/write
something there.
After this we can discuss if/how/when to integrate in core Pivot, and see
what others think. There is always the problem of external dependencies
etc, but we have more time for all this stuff.
Tell me if it's ok, and of course if you need info/help ask to us.
Thanks for now.
Bye,
Sandro
2013/4/18 teyckmans <te...@gmail.com>
> Hi Sandro,
>
> I'm happy to go with the option that you think is best. What is your
> prefference?
>
> Kind regards,
>
> Tom
>
>
>
> --
> View this message in context:
> http://apache-pivot-users.399431.n3.nabble.com/Guice-integration-for-apache-pivot-tp4022557p4022572.html
> Sent from the Apache Pivot - Users mailing list archive at Nabble.com.
>
Re: Guice integration for apache-pivot
Posted by teyckmans <te...@gmail.com>.
Hi Sandro,
I'm happy to go with the option that you think is best. What is your
prefference?
Kind regards,
Tom
--
View this message in context: http://apache-pivot-users.399431.n3.nabble.com/Guice-integration-for-apache-pivot-tp4022557p4022572.html
Sent from the Apache Pivot - Users mailing list archive at Nabble.com.
Re: Guice integration for apache-pivot
Posted by Sandro Martini <sa...@gmail.com>.
Hi Tom,
thank you very much for your contribution to Pivot.
If you are interested, we could publish it in one of our subprojects at
apache-extras (like pivot-contrib) by giving to you commit rights there and
a few small coding convention ... tell me if you want.
Otherwise, to integrate it in core Pivot we have more constraints by ASF
rules (licensing in the code and in related dependencies, etc) and project
(do not add external dependencies if not really needed, etc), and have in
attach to a JIRA issue ... if you want you could even create a new one and
attach the code there.
If you need more info ask to us.
Thank you for now,
Sandro
2013/4/8 Roger Whitcomb <Ro...@rbwhitcomb.com>
> Hi Tom,
> That is awesome! I will take a look and comment more in a bit. But
> I'm really grateful for your efforts here.
>
> ~Roger Whitcomb
>
>
Re: Guice integration for apache-pivot
Posted by Roger Whitcomb <Ro...@rbwhitcomb.com>.
Hi Tom,
That is awesome! I will take a look and comment more in a bit. But I'm really grateful for your efforts here.
~Roger Whitcomb