You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/07/21 09:03:26 UTC
[GitHub] [camel-website] AemieJ opened a new pull request #434: feat: add github action for image optimization
AemieJ opened a new pull request #434:
URL: https://github.com/apache/camel-website/pull/434
* The performance due to lack of image compression lowers for the webpage. Gulp Imagemin wasn't showing the results as expected thus I chose to use a GitHub action which is easy, effective, and does lossless compression.
* This will be triggered each time a PR is created. The compression for the current status of the branch is shown in the snippet of the image below. ( More files were edited than the ones shown in the image )
* However, I require clarification on whether the images from the **public** folder only need to be compressed or from the **static** folder as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] AemieJ commented on a change in pull request #434: feat: add github action for image optimization
Posted by GitBox <gi...@apache.org>.
AemieJ commented on a change in pull request #434:
URL: https://github.com/apache/camel-website/pull/434#discussion_r459336446
##########
File path: .github/workflows/calibreapp-image-actions.yml
##########
@@ -0,0 +1,20 @@
+name: Compress images
+on: pull_request
+jobs:
+ build:
+ name: calibreapp/image-actions
+ runs-on: ubuntu-latest
+ steps:
+ - name: Checkout
+ uses: actions/checkout@master
+
+ - name: Compress Images
+ uses: calibreapp/image-actions@master
+ with:
+ githubToken: ${{ secrets.GITHUB_TOKEN }}
+ jpegQuality: "80"
+ jpegProgressive: false
+ pngQuality: "80"
+ webpQuality: "80"
+ ignorePaths: "node_modules/**,build"
Review comment:
As we don't need to include the images within the **static** folder, I think I will change the ignorePaths to static
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] zregvart commented on pull request #434: feat: add github action for image optimization
Posted by GitBox <gi...@apache.org>.
zregvart commented on pull request #434:
URL: https://github.com/apache/camel-website/pull/434#issuecomment-663225042
Doesn't seem like the action [can commit](https://github.com/apache/camel-website/pull/434/checks#step:4:96) the changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] AemieJ commented on pull request #434: feat: add github action for image optimization
Posted by GitBox <gi...@apache.org>.
AemieJ commented on pull request #434:
URL: https://github.com/apache/camel-website/pull/434#issuecomment-663355701
> Doesn't seem like the action [can commit](https://github.com/apache/camel-website/pull/434/checks#step:4:96) the changes.
I believe it's only when you merge this and a PR is then on a PR, the action will take place. 'cause when I took one of the branches and created a PR in AemieJ/image-optimization. Then it takes the action into account and optimizes the image files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] zregvart commented on a change in pull request #434: feat: add github action for image optimization
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #434:
URL: https://github.com/apache/camel-website/pull/434#discussion_r459118698
##########
File path: .github/workflows/calibreapp-image-actions.yml
##########
@@ -0,0 +1,20 @@
+name: Compress images
+on: pull_request
+jobs:
+ build:
+ name: calibreapp/image-actions
+ runs-on: ubuntu-latest
+ steps:
+ - name: Checkout
+ uses: actions/checkout@master
+
+ - name: Compress Images
+ uses: calibreapp/image-actions@master
+ with:
+ githubToken: ${{ secrets.GITHUB_TOKEN }}
+ jpegQuality: "80"
+ jpegProgressive: false
+ pngQuality: "80"
+ webpQuality: "80"
+ ignorePaths: "node_modules/**,build"
Review comment:
I don't think we need this we don't have node_modules nor build directories. Would this include only `public`?
```suggestion
ignorePaths: "!public"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] AemieJ closed pull request #434: feat: add github action for image optimization
Posted by GitBox <gi...@apache.org>.
AemieJ closed pull request #434:
URL: https://github.com/apache/camel-website/pull/434
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] zregvart commented on pull request #434: feat: add github action for image optimization
Posted by GitBox <gi...@apache.org>.
zregvart commented on pull request #434:
URL: https://github.com/apache/camel-website/pull/434#issuecomment-662728825
> * However, I require clarification on whether the images from the **public** folder only need to be compressed or from the **static** folder as well?
I think we can optimize only images that are in `public`, those will end up published on the website.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] AemieJ edited a comment on pull request #434: feat: add github action for image optimization
Posted by GitBox <gi...@apache.org>.
AemieJ edited a comment on pull request #434:
URL: https://github.com/apache/camel-website/pull/434#issuecomment-663355701
> Doesn't seem like the action [can commit](https://github.com/apache/camel-website/pull/434/checks#step:4:96) the changes.
I believe it's only when you merge this and a PR is then on a PR, the action will take place. 'cause when I took one of the branches on my repo and created a PR in AemieJ/image-optimization then it takes the action into account and optimizes the image files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org