You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2019/07/16 12:24:17 UTC
Review Request 71081: Exposed agent drain information in the webui.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71081/
-----------------------------------------------------------
Review request for mesos, Greg Mann and Joseph Wu.
Bugs: MESOS-9846
https://issues.apache.org/jira/browse/MESOS-9846
Repository: mesos
Description
-------
Exposed agent drain information in the webui.
Diffs
-----
src/webui/app/agents/agent.html 6d50bfd320973687dcba0aaf2a2aa5d843679ea5
src/webui/app/agents/agents.html 98712c619fb58acf06b465b53d4c9dee85f8841d
Diff: https://reviews.apache.org/r/71081/diff/1/
Testing
-------
File Attachments
----------------
agents summary
https://reviews.apache.org/media/uploaded/files/2019/07/16/f21569fa-fdb5-4563-ac5d-2d7392bf3914__Screen_Shot_2019-07-16_at_2.03.43_PM.png
agent detail
https://reviews.apache.org/media/uploaded/files/2019/07/16/ae8bf9c8-584c-4afe-acbd-650258223933__Screen_Shot_2019-07-16_at_2.03.07_PM.png
Thanks,
Benjamin Bannier
Re: Review Request 71081: Exposed agent drain information in the
webui.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71081/#review216856
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71081]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On July 25, 2019, 8:52 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71081/
> -----------------------------------------------------------
>
> (Updated July 25, 2019, 8:52 a.m.)
>
>
> Review request for mesos, Greg Mann and Joseph Wu.
>
>
> Bugs: MESOS-9846
> https://issues.apache.org/jira/browse/MESOS-9846
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Exposed agent drain information in the webui.
>
>
> Diffs
> -----
>
> src/webui/app/agents/agent.html 6d50bfd320973687dcba0aaf2a2aa5d843679ea5
> src/webui/app/agents/agents.html 98712c619fb58acf06b465b53d4c9dee85f8841d
> src/webui/app/controllers.js 66cd32e666ba490b1194fc8b52bf2db199efdbc9
>
>
> Diff: https://reviews.apache.org/r/71081/diff/3/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> agents summary
> https://reviews.apache.org/media/uploaded/files/2019/07/16/f21569fa-fdb5-4563-ac5d-2d7392bf3914__Screen_Shot_2019-07-16_at_2.03.43_PM.png
> agent detail
> https://reviews.apache.org/media/uploaded/files/2019/07/16/ae8bf9c8-584c-4afe-acbd-650258223933__Screen_Shot_2019-07-16_at_2.03.07_PM.png
> agents summary
> https://reviews.apache.org/media/uploaded/files/2019/07/17/2baa2933-1e98-47f2-bdd5-1cb3a08817f2__Screen_Shot_2019-07-17_at_10.28.37_PM.png
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71081: Exposed agent drain information in the
webui.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71081/
-----------------------------------------------------------
(Updated July 25, 2019, 10:52 a.m.)
Review request for mesos, Greg Mann and Joseph Wu.
Changes
-------
Fix units
Bugs: MESOS-9846
https://issues.apache.org/jira/browse/MESOS-9846
Repository: mesos
Description
-------
Exposed agent drain information in the webui.
Diffs (updated)
-----
src/webui/app/agents/agent.html 6d50bfd320973687dcba0aaf2a2aa5d843679ea5
src/webui/app/agents/agents.html 98712c619fb58acf06b465b53d4c9dee85f8841d
src/webui/app/controllers.js 66cd32e666ba490b1194fc8b52bf2db199efdbc9
Diff: https://reviews.apache.org/r/71081/diff/3/
Changes: https://reviews.apache.org/r/71081/diff/2-3/
Testing
-------
File Attachments
----------------
agents summary
https://reviews.apache.org/media/uploaded/files/2019/07/16/f21569fa-fdb5-4563-ac5d-2d7392bf3914__Screen_Shot_2019-07-16_at_2.03.43_PM.png
agent detail
https://reviews.apache.org/media/uploaded/files/2019/07/16/ae8bf9c8-584c-4afe-acbd-650258223933__Screen_Shot_2019-07-16_at_2.03.07_PM.png
agents summary
https://reviews.apache.org/media/uploaded/files/2019/07/17/2baa2933-1e98-47f2-bdd5-1cb3a08817f2__Screen_Shot_2019-07-17_at_10.28.37_PM.png
Thanks,
Benjamin Bannier
Re: Review Request 71081: Exposed agent drain information in the
webui.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71081/#review216702
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71081]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On July 17, 2019, 8:31 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71081/
> -----------------------------------------------------------
>
> (Updated July 17, 2019, 8:31 p.m.)
>
>
> Review request for mesos, Greg Mann and Joseph Wu.
>
>
> Bugs: MESOS-9846
> https://issues.apache.org/jira/browse/MESOS-9846
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Exposed agent drain information in the webui.
>
>
> Diffs
> -----
>
> src/webui/app/agents/agent.html 6d50bfd320973687dcba0aaf2a2aa5d843679ea5
> src/webui/app/agents/agents.html 98712c619fb58acf06b465b53d4c9dee85f8841d
> src/webui/app/controllers.js 66cd32e666ba490b1194fc8b52bf2db199efdbc9
>
>
> Diff: https://reviews.apache.org/r/71081/diff/2/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> agents summary
> https://reviews.apache.org/media/uploaded/files/2019/07/16/f21569fa-fdb5-4563-ac5d-2d7392bf3914__Screen_Shot_2019-07-16_at_2.03.43_PM.png
> agent detail
> https://reviews.apache.org/media/uploaded/files/2019/07/16/ae8bf9c8-584c-4afe-acbd-650258223933__Screen_Shot_2019-07-16_at_2.03.07_PM.png
> agents summary
> https://reviews.apache.org/media/uploaded/files/2019/07/17/2baa2933-1e98-47f2-bdd5-1cb3a08817f2__Screen_Shot_2019-07-17_at_10.28.37_PM.png
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71081: Exposed agent drain information in the
webui.
Posted by Benjamin Bannier <bb...@apache.org>.
> On July 25, 2019, 2:34 a.m., Greg Mann wrote:
> > src/webui/app/agents/agent.html
> > Lines 65 (patched)
> > <https://reviews.apache.org/r/71081/diff/2/?file=2155831#file2155831line65>
> >
> > Looks like this conversion is off by a factor of 1000?
It is, thanks for catching this.
This came about because I was initially trying to format a deadline as a `m-timestamp` which requires millisecond input.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71081/#review216840
-----------------------------------------------------------
On July 25, 2019, 10:52 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71081/
> -----------------------------------------------------------
>
> (Updated July 25, 2019, 10:52 a.m.)
>
>
> Review request for mesos, Greg Mann and Joseph Wu.
>
>
> Bugs: MESOS-9846
> https://issues.apache.org/jira/browse/MESOS-9846
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Exposed agent drain information in the webui.
>
>
> Diffs
> -----
>
> src/webui/app/agents/agent.html 6d50bfd320973687dcba0aaf2a2aa5d843679ea5
> src/webui/app/agents/agents.html 98712c619fb58acf06b465b53d4c9dee85f8841d
> src/webui/app/controllers.js 66cd32e666ba490b1194fc8b52bf2db199efdbc9
>
>
> Diff: https://reviews.apache.org/r/71081/diff/3/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> agents summary
> https://reviews.apache.org/media/uploaded/files/2019/07/16/f21569fa-fdb5-4563-ac5d-2d7392bf3914__Screen_Shot_2019-07-16_at_2.03.43_PM.png
> agent detail
> https://reviews.apache.org/media/uploaded/files/2019/07/16/ae8bf9c8-584c-4afe-acbd-650258223933__Screen_Shot_2019-07-16_at_2.03.07_PM.png
> agents summary
> https://reviews.apache.org/media/uploaded/files/2019/07/17/2baa2933-1e98-47f2-bdd5-1cb3a08817f2__Screen_Shot_2019-07-17_at_10.28.37_PM.png
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71081: Exposed agent drain information in the
webui.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71081/#review216840
-----------------------------------------------------------
Fix it, then Ship it!
src/webui/app/agents/agent.html
Lines 65 (patched)
<https://reviews.apache.org/r/71081/#comment304089>
Looks like this conversion is off by a factor of 1000?
- Greg Mann
On July 17, 2019, 8:31 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71081/
> -----------------------------------------------------------
>
> (Updated July 17, 2019, 8:31 p.m.)
>
>
> Review request for mesos, Greg Mann and Joseph Wu.
>
>
> Bugs: MESOS-9846
> https://issues.apache.org/jira/browse/MESOS-9846
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Exposed agent drain information in the webui.
>
>
> Diffs
> -----
>
> src/webui/app/agents/agent.html 6d50bfd320973687dcba0aaf2a2aa5d843679ea5
> src/webui/app/agents/agents.html 98712c619fb58acf06b465b53d4c9dee85f8841d
> src/webui/app/controllers.js 66cd32e666ba490b1194fc8b52bf2db199efdbc9
>
>
> Diff: https://reviews.apache.org/r/71081/diff/2/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> agents summary
> https://reviews.apache.org/media/uploaded/files/2019/07/16/f21569fa-fdb5-4563-ac5d-2d7392bf3914__Screen_Shot_2019-07-16_at_2.03.43_PM.png
> agent detail
> https://reviews.apache.org/media/uploaded/files/2019/07/16/ae8bf9c8-584c-4afe-acbd-650258223933__Screen_Shot_2019-07-16_at_2.03.07_PM.png
> agents summary
> https://reviews.apache.org/media/uploaded/files/2019/07/17/2baa2933-1e98-47f2-bdd5-1cb3a08817f2__Screen_Shot_2019-07-17_at_10.28.37_PM.png
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71081: Exposed agent drain information in the
webui.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71081/
-----------------------------------------------------------
(Updated July 17, 2019, 10:31 p.m.)
Review request for mesos, Greg Mann and Joseph Wu.
Changes
-------
Display generic "agent state" in `agents` screen instead of just drain state
Bugs: MESOS-9846
https://issues.apache.org/jira/browse/MESOS-9846
Repository: mesos
Description
-------
Exposed agent drain information in the webui.
Diffs (updated)
-----
src/webui/app/agents/agent.html 6d50bfd320973687dcba0aaf2a2aa5d843679ea5
src/webui/app/agents/agents.html 98712c619fb58acf06b465b53d4c9dee85f8841d
src/webui/app/controllers.js 66cd32e666ba490b1194fc8b52bf2db199efdbc9
Diff: https://reviews.apache.org/r/71081/diff/2/
Changes: https://reviews.apache.org/r/71081/diff/1-2/
Testing
-------
File Attachments (updated)
----------------
agents summary
https://reviews.apache.org/media/uploaded/files/2019/07/16/f21569fa-fdb5-4563-ac5d-2d7392bf3914__Screen_Shot_2019-07-16_at_2.03.43_PM.png
agent detail
https://reviews.apache.org/media/uploaded/files/2019/07/16/ae8bf9c8-584c-4afe-acbd-650258223933__Screen_Shot_2019-07-16_at_2.03.07_PM.png
agents summary
https://reviews.apache.org/media/uploaded/files/2019/07/17/2baa2933-1e98-47f2-bdd5-1cb3a08817f2__Screen_Shot_2019-07-17_at_10.28.37_PM.png
Thanks,
Benjamin Bannier
Re: Review Request 71081: Exposed agent drain information in the
webui.
Posted by Benjamin Bannier <bb...@apache.org>.
> On July 16, 2019, 2:25 p.m., Benjamin Bannier wrote:
> > src/webui/app/agents/agent.html
> > Lines 65 (patched)
> > <https://reviews.apache.org/r/71081/diff/1/?file=2155221#file2155221line65>
> >
> > This information is essential useless to users as they have no idea at what point tasks would slip out of the grace period (interval without start time).
>
> Greg Mann wrote:
> I think this is fine; it's difficult for the master to say exactly when draining has actually begun on an agent, since the agent doesn't ACK the `DrainSlaveMessage`. Unless we have some idea of how to make this more meaningful without lots of effort, I'd say leave as-is.
I don't think we would need exact information. If the master could e.g., keep the last time a `DrainSlaveMessage` was sent to the agent in memory and expose it here one would be able to infer a deadline on a sub-minute level (unless the agent is completely overloaded ¯\_(?)_/¯). This information is always only a best guess since e.g., an agent failover could reset the clock, by potentially triggering another drain cycle.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71081/#review216650
-----------------------------------------------------------
On July 25, 2019, 10:52 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71081/
> -----------------------------------------------------------
>
> (Updated July 25, 2019, 10:52 a.m.)
>
>
> Review request for mesos, Greg Mann and Joseph Wu.
>
>
> Bugs: MESOS-9846
> https://issues.apache.org/jira/browse/MESOS-9846
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Exposed agent drain information in the webui.
>
>
> Diffs
> -----
>
> src/webui/app/agents/agent.html 6d50bfd320973687dcba0aaf2a2aa5d843679ea5
> src/webui/app/agents/agents.html 98712c619fb58acf06b465b53d4c9dee85f8841d
> src/webui/app/controllers.js 66cd32e666ba490b1194fc8b52bf2db199efdbc9
>
>
> Diff: https://reviews.apache.org/r/71081/diff/3/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> agents summary
> https://reviews.apache.org/media/uploaded/files/2019/07/16/f21569fa-fdb5-4563-ac5d-2d7392bf3914__Screen_Shot_2019-07-16_at_2.03.43_PM.png
> agent detail
> https://reviews.apache.org/media/uploaded/files/2019/07/16/ae8bf9c8-584c-4afe-acbd-650258223933__Screen_Shot_2019-07-16_at_2.03.07_PM.png
> agents summary
> https://reviews.apache.org/media/uploaded/files/2019/07/17/2baa2933-1e98-47f2-bdd5-1cb3a08817f2__Screen_Shot_2019-07-17_at_10.28.37_PM.png
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71081: Exposed agent drain information in the
webui.
Posted by Greg Mann <gr...@mesosphere.io>.
> On July 16, 2019, 12:25 p.m., Benjamin Bannier wrote:
> > src/webui/app/agents/agent.html
> > Lines 65 (patched)
> > <https://reviews.apache.org/r/71081/diff/1/?file=2155221#file2155221line65>
> >
> > This information is essential useless to users as they have no idea at what point tasks would slip out of the grace period (interval without start time).
I think this is fine; it's difficult for the master to say exactly when draining has actually begun on an agent, since the agent doesn't ACK the `DrainSlaveMessage`. Unless we have some idea of how to make this more meaningful without lots of effort, I'd say leave as-is.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71081/#review216650
-----------------------------------------------------------
On July 17, 2019, 8:31 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71081/
> -----------------------------------------------------------
>
> (Updated July 17, 2019, 8:31 p.m.)
>
>
> Review request for mesos, Greg Mann and Joseph Wu.
>
>
> Bugs: MESOS-9846
> https://issues.apache.org/jira/browse/MESOS-9846
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Exposed agent drain information in the webui.
>
>
> Diffs
> -----
>
> src/webui/app/agents/agent.html 6d50bfd320973687dcba0aaf2a2aa5d843679ea5
> src/webui/app/agents/agents.html 98712c619fb58acf06b465b53d4c9dee85f8841d
> src/webui/app/controllers.js 66cd32e666ba490b1194fc8b52bf2db199efdbc9
>
>
> Diff: https://reviews.apache.org/r/71081/diff/2/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> agents summary
> https://reviews.apache.org/media/uploaded/files/2019/07/16/f21569fa-fdb5-4563-ac5d-2d7392bf3914__Screen_Shot_2019-07-16_at_2.03.43_PM.png
> agent detail
> https://reviews.apache.org/media/uploaded/files/2019/07/16/ae8bf9c8-584c-4afe-acbd-650258223933__Screen_Shot_2019-07-16_at_2.03.07_PM.png
> agents summary
> https://reviews.apache.org/media/uploaded/files/2019/07/17/2baa2933-1e98-47f2-bdd5-1cb3a08817f2__Screen_Shot_2019-07-17_at_10.28.37_PM.png
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71081: Exposed agent drain information in the
webui.
Posted by Greg Mann <gr...@mesosphere.io>.
> On July 16, 2019, 12:25 p.m., Benjamin Bannier wrote:
> > src/webui/app/agents/agent.html
> > Lines 65 (patched)
> > <https://reviews.apache.org/r/71081/diff/1/?file=2155221#file2155221line65>
> >
> > This information is essential useless to users as they have no idea at what point tasks would slip out of the grace period (interval without start time).
>
> Greg Mann wrote:
> I think this is fine; it's difficult for the master to say exactly when draining has actually begun on an agent, since the agent doesn't ACK the `DrainSlaveMessage`. Unless we have some idea of how to make this more meaningful without lots of effort, I'd say leave as-is.
>
> Benjamin Bannier wrote:
> I don't think we would need exact information. If the master could e.g., keep the last time a `DrainSlaveMessage` was sent to the agent in memory and expose it here one would be able to infer a deadline on a sub-minute level (unless the agent is completely overloaded ¯\_(?)_/¯). This information is always only a best guess since e.g., an agent failover could reset the clock, by potentially triggering another drain cycle.
Sounds like a good plan to me, and simple :)
Here's a JIRA: https://issues.apache.org/jira/browse/MESOS-9907
Let's follow up on this ASAP. Dropping this issue for now.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71081/#review216650
-----------------------------------------------------------
On July 25, 2019, 8:52 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71081/
> -----------------------------------------------------------
>
> (Updated July 25, 2019, 8:52 a.m.)
>
>
> Review request for mesos, Greg Mann and Joseph Wu.
>
>
> Bugs: MESOS-9846
> https://issues.apache.org/jira/browse/MESOS-9846
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Exposed agent drain information in the webui.
>
>
> Diffs
> -----
>
> src/webui/app/agents/agent.html 6d50bfd320973687dcba0aaf2a2aa5d843679ea5
> src/webui/app/agents/agents.html 98712c619fb58acf06b465b53d4c9dee85f8841d
> src/webui/app/controllers.js 66cd32e666ba490b1194fc8b52bf2db199efdbc9
>
>
> Diff: https://reviews.apache.org/r/71081/diff/3/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> agents summary
> https://reviews.apache.org/media/uploaded/files/2019/07/16/f21569fa-fdb5-4563-ac5d-2d7392bf3914__Screen_Shot_2019-07-16_at_2.03.43_PM.png
> agent detail
> https://reviews.apache.org/media/uploaded/files/2019/07/16/ae8bf9c8-584c-4afe-acbd-650258223933__Screen_Shot_2019-07-16_at_2.03.07_PM.png
> agents summary
> https://reviews.apache.org/media/uploaded/files/2019/07/17/2baa2933-1e98-47f2-bdd5-1cb3a08817f2__Screen_Shot_2019-07-17_at_10.28.37_PM.png
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71081: Exposed agent drain information in the
webui.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71081/#review216650
-----------------------------------------------------------
src/webui/app/agents/agent.html
Lines 65 (patched)
<https://reviews.apache.org/r/71081/#comment303855>
This information is essential useless to users as they have no idea at what point tasks would slip out of the grace period (interval without start time).
- Benjamin Bannier
On July 16, 2019, 2:24 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71081/
> -----------------------------------------------------------
>
> (Updated July 16, 2019, 2:24 p.m.)
>
>
> Review request for mesos, Greg Mann and Joseph Wu.
>
>
> Bugs: MESOS-9846
> https://issues.apache.org/jira/browse/MESOS-9846
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Exposed agent drain information in the webui.
>
>
> Diffs
> -----
>
> src/webui/app/agents/agent.html 6d50bfd320973687dcba0aaf2a2aa5d843679ea5
> src/webui/app/agents/agents.html 98712c619fb58acf06b465b53d4c9dee85f8841d
>
>
> Diff: https://reviews.apache.org/r/71081/diff/1/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> agents summary
> https://reviews.apache.org/media/uploaded/files/2019/07/16/f21569fa-fdb5-4563-ac5d-2d7392bf3914__Screen_Shot_2019-07-16_at_2.03.43_PM.png
> agent detail
> https://reviews.apache.org/media/uploaded/files/2019/07/16/ae8bf9c8-584c-4afe-acbd-650258223933__Screen_Shot_2019-07-16_at_2.03.07_PM.png
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71081: Exposed agent drain information in the
webui.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71081/#review216660
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71081]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On July 16, 2019, 12:24 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71081/
> -----------------------------------------------------------
>
> (Updated July 16, 2019, 12:24 p.m.)
>
>
> Review request for mesos, Greg Mann and Joseph Wu.
>
>
> Bugs: MESOS-9846
> https://issues.apache.org/jira/browse/MESOS-9846
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Exposed agent drain information in the webui.
>
>
> Diffs
> -----
>
> src/webui/app/agents/agent.html 6d50bfd320973687dcba0aaf2a2aa5d843679ea5
> src/webui/app/agents/agents.html 98712c619fb58acf06b465b53d4c9dee85f8841d
>
>
> Diff: https://reviews.apache.org/r/71081/diff/1/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> agents summary
> https://reviews.apache.org/media/uploaded/files/2019/07/16/f21569fa-fdb5-4563-ac5d-2d7392bf3914__Screen_Shot_2019-07-16_at_2.03.43_PM.png
> agent detail
> https://reviews.apache.org/media/uploaded/files/2019/07/16/ae8bf9c8-584c-4afe-acbd-650258223933__Screen_Shot_2019-07-16_at_2.03.07_PM.png
>
>
> Thanks,
>
> Benjamin Bannier
>
>