You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/05/21 15:37:36 UTC

[GitHub] [maven-dependency-plugin] ian-lavallee opened a new pull request #54: [MDEP-644] [DRAFT] Reintroduce the verbose option for dependency:tree

ian-lavallee opened a new pull request #54:
URL: https://github.com/apache/maven-dependency-plugin/pull/54


   @elharo 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-dependency-plugin] elharo closed pull request #54: [MDEP-644] [DRAFT] Reintroduce the verbose option for dependency:tree

Posted by GitBox <gi...@apache.org>.
elharo closed pull request #54:
URL: https://github.com/apache/maven-dependency-plugin/pull/54


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-dependency-plugin] elharo commented on a change in pull request #54: [MDEP-644] [DRAFT] Reintroduce the verbose option for dependency:tree

Posted by GitBox <gi...@apache.org>.
elharo commented on a change in pull request #54:
URL: https://github.com/apache/maven-dependency-plugin/pull/54#discussion_r431421831



##########
File path: pom.xml
##########
@@ -275,6 +271,33 @@ under the License.
       <artifactId>maven-plugin-annotations</artifactId>
     </dependency>
 
+    <!-- aether -->
+    <dependency>
+      <groupId>org.eclipse.aether</groupId>

Review comment:
       This is still an old version. You want maven-resolver:
   
   <dependency>
       <groupId>org.apache.maven.resolver</groupId>
       <artifactId>maven-resolver-api</artifactId>
       <version>1.4.2</version>
   </dependency>
   

##########
File path: src/main/java/org/apache/maven/plugins/dependency/tree/DependencyGraphBuilder.java
##########
@@ -0,0 +1,64 @@
+package org.apache.maven.plugins.dependency.tree;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.artifact.resolver.filter.ArtifactFilter;
+import org.apache.maven.project.MavenProject;
+import org.apache.maven.project.ProjectBuildingRequest;
+
+
+import java.util.Collection;
+
+/**
+ * Maven project dependency graph builder API, neutral against Maven 2 or Maven 3.

Review comment:
       no longer neutral




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org