You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/11/30 13:20:04 UTC
[GitHub] [camel] sekikn opened a new pull request, #8803: CAMEL-18776: camel-hdfs - Fix HdfsNormalFileHandler to handle temporary file path correctly
sekikn opened a new pull request, #8803:
URL: https://github.com/apache/camel/pull/8803
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8803: CAMEL-18776: camel-hdfs - Fix HdfsNormalFileHandler to handle temporary file path correctly
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8803:
URL: https://github.com/apache/camel/pull/8803#issuecomment-1332221392
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 1 | 1 | 0 | 1 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #8803: CAMEL-18776: camel-hdfs - Fix HdfsNormalFileHandler to handle temporary file path correctly
Posted by GitBox <gi...@apache.org>.
davsclaus merged PR #8803:
URL: https://github.com/apache/camel/pull/8803
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #8803: CAMEL-18776: camel-hdfs - Fix HdfsNormalFileHandler to handle temporary file path correctly
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #8803:
URL: https://github.com/apache/camel/pull/8803#issuecomment-1332147298
Thank you very much
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] sekikn commented on pull request #8803: CAMEL-18776: camel-hdfs - Fix HdfsNormalFileHandler to handle temporary file path correctly
Posted by GitBox <gi...@apache.org>.
sekikn commented on PR #8803:
URL: https://github.com/apache/camel/pull/8803#issuecomment-1332145754
For ensuring this fix is correct, I set up HDFS locally and ran HdfsProducerConsumerIntegrationManualIT manually by removing its `@Disabled` annotation. It succeeded as follows.
```
$ cd components/camel-hdfs
$ ../../mvnw test -Dtest=org.apache.camel.component.hdfs.integration.HdfsProducerConsumerIntegrationManualIT
...
[INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @ camel-hdfs ---
[INFO]
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.camel.component.hdfs.integration.HdfsProducerConsumerIntegrationManualIT
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 20.335 s - in org.apache.camel.component.hdfs.integration.HdfsProducerConsumerIntegrationManualIT
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 26.491 s
[INFO] Finished at: 2022-11-30T22:12:39+09:00
[INFO] ------------------------------------------------------------------------
```
Without this fix, these tests fail:
```
[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] org.apache.camel.component.hdfs.integration.HdfsProducerConsumerIntegrationManualIT.testMultipleConsumers
[ERROR] Run 1: HdfsProducerConsumerIntegrationManualIT.testMultipleConsumers:128 mock://result Received message count. Expected: <400> but was: <0>
[ERROR] Run 2: HdfsProducerConsumerIntegrationManualIT.testMultipleConsumers:128 mock://result Received message count. Expected: <400> but was: <0>
[ERROR] Run 3: HdfsProducerConsumerIntegrationManualIT.testMultipleConsumers:128 mock://result Received message count. Expected: <400> but was: <0>
[INFO]
[ERROR] org.apache.camel.component.hdfs.integration.HdfsProducerConsumerIntegrationManualIT.testSimpleSplitWriteRead
[ERROR] Run 1: HdfsProducerConsumerIntegrationManualIT.testSimpleSplitWriteRead:74 mock://result Received message count. Expected: <10> but was: <0>
[ERROR] Run 2: HdfsProducerConsumerIntegrationManualIT.testSimpleSplitWriteRead:74 mock://result Received message count. Expected: <10> but was: <0>
[ERROR] Run 3: HdfsProducerConsumerIntegrationManualIT.testSimpleSplitWriteRead:74 mock://result Received message count. Expected: <10> but was: <0>
[INFO]
[INFO]
[ERROR] Tests run: 2, Failures: 2, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 06:18 min
[INFO] Finished at: 2022-11-30T22:19:37+09:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test (default-test) on project camel-hdfs: There are test failures.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8803: CAMEL-18776: camel-hdfs - Fix HdfsNormalFileHandler to handle temporary file path correctly
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8803:
URL: https://github.com/apache/camel/pull/8803#issuecomment-1332144940
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:warning: Please note that the changes on this PR may be **tested automatically**.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org