You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2025/03/01 00:03:49 UTC
[Impala-ASF-CR] IMPALA-13716 (Addendum): Add a method for external frontend
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22564 )
Change subject: IMPALA-13716 (Addendum): Add a method for external frontend
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22564/1/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java
File fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java:
http://gerrit.cloudera.org:8080/#/c/22564/1/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java@162
PS1, Line 162:
: /**
: * Provided for an external frontend that does not supply a List of
: * TupleIsNullPredicate.
: */
: public PlanNode createSingleNodePlan(PlanNode root,
: List<Expr> groupingExprs, List<Expr> inputPartitionExprs) throws ImpalaException {
> Can you refactor following call site to use this new constructor please?
Once you do that, getTupleIsNullPreds can be moved as a private method here instead of making it a public method in SingleNodePlanner.
--
To view, visit http://gerrit.cloudera.org:8080/22564
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie10361f15db4c0eb2cf5ff5f4d0a28c612b1a930
Gerrit-Change-Number: 22564
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Sat, 01 Mar 2025 00:03:49 +0000
Gerrit-HasComments: Yes