You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/08/08 19:54:08 UTC

[GitHub] [fineract] thesmallstar opened a new pull request #1242: FINERACT-821 Added and Enforced MemberName Checkstyle(2)

thesmallstar opened a new pull request #1242:
URL: https://github.com/apache/fineract/pull/1242


   Refer: https://issues.apache.org/jira/browse/FINERACT-821
   I have suppressed the checkstyle where I thought it is not a good idea to change how we are naming, like database Schemas in swagger. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] ptuomola commented on pull request #1242: FINERACT-821 Added and Enforced MemberName Checkstyle(2)

Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1242:
URL: https://github.com/apache/fineract/pull/1242#issuecomment-672779492


   Looking at this, the changes seem to fall into a couple of different categories:
   
   - ones where it makes sense - e.g. is_active to isActive
   
   - ones where it in my view doesn't really make sense - e.g. S3, SMS etc are acronyms that are capitalised, so to make them lowercase just because they are in a variable name seems strange
   
   - ones where we are taking a fully capitalised variable and making that camelcase. I'm wondering if these should actually be static constants rather than variables in the first place?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] thesmallstar commented on pull request #1242: FINERACT-821 Added and Enforced MemberName Checkstyle(2)

Posted by GitBox <gi...@apache.org>.
thesmallstar commented on pull request #1242:
URL: https://github.com/apache/fineract/pull/1242#issuecomment-673077724


   @ptuomola I thought not to make them static since they are used in that class itself, I thought there is no use to make them static since they are not used elsewhere if you think the static makes more sense I will change it ;)
   
   Should I instead suppress the checkstyle for point "2" then? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] ptuomola commented on pull request #1242: FINERACT-821 Added and Enforced MemberName Checkstyle(2)

Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1242:
URL: https://github.com/apache/fineract/pull/1242#issuecomment-677025303


   @thesmallstar Thanks for your reply! I think it's all just a matter of preference and what you're used to seeing :-) 
   
   But I think consistency is more important than trying to adhere to anyone's specific preferences. 
   
   So to make things consistent re member naming, let's merge your change as proposed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] ptuomola merged pull request #1242: FINERACT-821 Added and Enforced MemberName Checkstyle(2)

Posted by GitBox <gi...@apache.org>.
ptuomola merged pull request #1242:
URL: https://github.com/apache/fineract/pull/1242


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org