[jira] [Commented] (HADOOP-6311) Add support for unix domain sockets to JNI libs

["Todd Lipcon (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279843#comment-13279843 ] 

Todd Lipcon commented on HADOOP-6311:
-------------------------------------

Thanks for updating this, Brock! A few comments looking over the patch:

- get_pw_buflen now seems to show up twice in NativeIO.c
- we need to add interface annotations to the new public classes - I guess LimitedPrivate for HDFS is the right choice
- in java_opt_to_real, I think we should use javah-produced constants to get the numeric values corresponding to java.net.SocketOptions here. The case statements with magic number ints are a little hard to explain

If you dont have time to do the above, I can rev the patch
                
> Add support for unix domain sockets to JNI libs
> -----------------------------------------------
>
>                 Key: HADOOP-6311
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6311
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: native
>    Affects Versions: 0.20.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: 6311-trunk-inprogress.txt, HADOOP-6311-0.patch, hadoop-6311.txt
>
>
> For HDFS-347 we need to use unix domain sockets. This JIRA is to include a library in common which adds a o.a.h.net.unix package based on the code from Android (apache 2 license)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira