You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "stevomitric (via GitHub)" <gi...@apache.org> on 2026/08/12 12:28:28 UTC
[PR] [SPARK-58739][SQL][TEST] Test UnsafeRow nested struct/map round-trip for nanos timestamps [spark]
stevomitric opened a new pull request, #57961:
URL: https://github.com/apache/spark/pull/57961
### What changes were proposed in this pull request?
Adds coverage for nanosecond timestamp values inside nested UnsafeRow structures, which was implemented but untested:
- Nested StructType fields (NTZ + LTZ), including null fields inside a non-null struct, and a nanos field alongside a variable-length StringType field.
- MapType values (NTZ nullable with an interior null; LTZ non-nullable), read back through UnsafeRow.getMap().valueArray().
Each case runs through both the codegen and interpreted UnsafeProjection paths via testBothCodegenAndInterpreted, mirroring the existing array round-trip tests.
### Why are the changes needed?
Extend the test coverage.
### Does this PR introduce _any_ user-facing change?
No. Test only change.
### How was this patch tested?
Test-only change.
### Was this patch authored or co-authored using generative AI tooling?
Co-Authored: Claude Opus 4.8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58739][SQL][TEST] Test UnsafeRow nested struct/map round-trip for nanos timestamps [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #57961:
URL: https://github.com/apache/spark/pull/57961#issuecomment-5271030330
**Merge Summary:**
- merged into master https://github.com/apache/spark/commit/36b15ae916b5396026ae70bed2c76094afa5c59d
- merged into branch-4.x https://github.com/apache/spark/commit/3af65ad7c433954bdfb13088a88eeb909afc0cb2
- merged into branch-4.3 https://github.com/apache/spark/commit/185f135bacabc237eef2373f1be40694de601704
*Posted by `merge_spark_pr.py`*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [WIP][SPARK-58739][SQL][TEST] Test UnsafeRow nested struct/map round-trip for nanos timestamps [spark]
Posted by "stevomitric (via GitHub)" <gi...@apache.org>.
stevomitric commented on PR #57961:
URL: https://github.com/apache/spark/pull/57961#issuecomment-5267174760
cc @uros-b, @cloud-fan PTAL when you get a chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58739][SQL][TEST] Test UnsafeRow nested struct/map round-trip for nanos timestamps [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b closed pull request #57961: [SPARK-58739][SQL][TEST] Test UnsafeRow nested struct/map round-trip for nanos timestamps
URL: https://github.com/apache/spark/pull/57961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58739][SQL][TEST] Test UnsafeRow nested struct/map round-trip for nanos timestamps [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #57961:
URL: https://github.com/apache/spark/pull/57961#issuecomment-5268492943
Thank you @stevomitric and @cloud-fan!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org