Re: [PR] KAFKA-16437 - Upgrade to Jakarta and Jetty 12 (KIP-1032) [kafka]

["mumrah (via GitHub)" <gi...@apache.org>]

mumrah commented on code in PR #16754:
URL: https://github.com/apache/kafka/pull/16754#discussion_r1872040064


##########
gradle/spotbugs-exclude.xml:
##########
@@ -562,4 +568,10 @@ For a detailed description of spotbugs bug categories, see https://spotbugs.read
         <Bug pattern="SING_SINGLETON_HAS_NONPRIVATE_CONSTRUCTOR"/>
     </Match>
 
+    <Match>
+        <!-- DateFormat is not used in more than one thread -->
+        <Class name="org.apache.kafka.tools.ReplicaVerificationTool$ReplicaBuffer"/>
+        <Bug pattern="STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE"/>

Review Comment:
   Did any relevant code change in this PR for this spotbugs exclusion?



##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java:
##########
@@ -1071,7 +1071,7 @@ private void awaitStopTask(ConnectorTaskId taskId, long timeout) {
             }
 
             if (!task.awaitStop(timeout)) {
-                log.error("Graceful stop of task {} failed.", task.id());
+                log.error(" Graceful stop of task {} failed.", task.id());

Review Comment:
   nit: did you mean to add this space?



##########
gradle/spotbugs-exclude.xml:
##########
@@ -40,6 +40,12 @@ For a detailed description of spotbugs bug categories, see https://spotbugs.read
         <Bug pattern="DM_EXIT"/>
     </Match>
 
+    <Match>
+        <!-- Disable warnings about doProvileged, This has been deprecated
+            as of JDK 17 for removal, see https://openjdk.org/jeps/411 -->
+        <Bug pattern="DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED"/>

Review Comment:
   This comment confused me at first. Can you include the description of `DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED` to make it clear to the reader?
   
   > Classloaders should only be created inside doPrivileged block



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org