You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/06/09 16:14:37 UTC
[GitHub] [hbase] HorizonNet commented on a change in pull request #1871: HBASE-24005 Document maven invocation with JDK11
HorizonNet commented on a change in pull request #1871:
URL: https://github.com/apache/hbase/pull/1871#discussion_r436925429
##########
File path: src/main/asciidoc/_chapters/developer.adoc
##########
@@ -420,6 +419,27 @@ Tests may not all pass so you may need to pass `-DskipTests` unless you are incl
To pick a particular Hadoop 3.y release, you'd set hadoop-three.version property e.g. `-Dhadoop-three.version=3.0.0`.
+[[maven.build.jdk11_hadoop3]]
+==== Building with JDK11 and Hadoop3
+
+The following guidance applies to HBase versions [2.3, 3), where both JDK8 and JDK11 are supported,
+and both Hadoop2 and Hadoop3 are supported.
+
+HBase manages JDK-specific build settings using maven profiles. The profile appropriate to the JDK
Review comment:
NIT: In some sections "Maven" with an upper-case "M" is used. Here it is lower-cased. I think it is better to stay consistent.
##########
File path: src/main/asciidoc/_chapters/developer.adoc
##########
@@ -420,6 +419,27 @@ Tests may not all pass so you may need to pass `-DskipTests` unless you are incl
To pick a particular Hadoop 3.y release, you'd set hadoop-three.version property e.g. `-Dhadoop-three.version=3.0.0`.
+[[maven.build.jdk11_hadoop3]]
+==== Building with JDK11 and Hadoop3
+
+The following guidance applies to HBase versions [2.3, 3), where both JDK8 and JDK11 are supported,
+and both Hadoop2 and Hadoop3 are supported.
+
+HBase manages JDK-specific build settings using maven profiles. The profile appropriate to the JDK
+in use is automatically selected. JDK8 supports both Hadoop2 and Hadoop3. For JDK11, only Hadoop3
+is supported, which means you must specify `-Dhadoop.profile=3.0` when building with JDK11.
Review comment:
Is this really necessary as the `hadoop-3.0` profile is active by default (at least on master)? Or better state it to make it generic for all mentioned releases?
##########
File path: src/main/asciidoc/_chapters/developer.adoc
##########
@@ -420,6 +419,27 @@ Tests may not all pass so you may need to pass `-DskipTests` unless you are incl
To pick a particular Hadoop 3.y release, you'd set hadoop-three.version property e.g. `-Dhadoop-three.version=3.0.0`.
+[[maven.build.jdk11_hadoop3]]
+==== Building with JDK11 and Hadoop3
+
+The following guidance applies to HBase versions [2.3, 3), where both JDK8 and JDK11 are supported,
+and both Hadoop2 and Hadoop3 are supported.
+
+HBase manages JDK-specific build settings using maven profiles. The profile appropriate to the JDK
+in use is automatically selected. JDK8 supports both Hadoop2 and Hadoop3. For JDK11, only Hadoop3
+is supported, which means you must specify `-Dhadoop.profile=3.0` when building with JDK11.
Review comment:
That's what I meant by the second question. For me it's totally fine. Just wanted to shortly discuss if we should make a distinction between the different releases or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org