You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "waitinfuture (via GitHub)" <gi...@apache.org> on 2023/07/24 07:07:52 UTC
[GitHub] [incubator-celeborn] waitinfuture opened a new pull request, #1752: [CELEBORN-826][DOC] Add storage document
waitinfuture opened a new pull request, #1752:
URL: https://github.com/apache/incubator-celeborn/pull/1752
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
As title.
### Why are the changes needed?
As title.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] cfmcgrady commented on a diff in pull request #1752: [CELEBORN-826][DOC] Add storage document
Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady commented on code in PR #1752:
URL: https://github.com/apache/incubator-celeborn/pull/1752#discussion_r1271874363
##########
client/src/test/scala/org/apache/celeborn/client/WorkerStatusTrackerSuite.scala:
##########
@@ -30,6 +30,22 @@ import org.apache.celeborn.common.protocol.message.StatusCode
class WorkerStatusTrackerSuite extends CelebornFunSuite {
+ def f(): Unit = {
+ val a = List(-1, 1)
+ a.foreach( v => {
+ if (v > 0) {
+ println("haha")
+ return
+ }
+ println("aaa")
+ }
+ )
+ }
+
+ test("test") {
Review Comment:
Oops...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1752: [CELEBORN-826][DOC] Add storage document
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1752:
URL: https://github.com/apache/incubator-celeborn/pull/1752#issuecomment-1647348983
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1752?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1752](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1752?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1434b26) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/8e849645eb3de0f6b889a14b45b618ad7a1de33c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (8e84964) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 1434b26 differs from pull request most recent head 309052b. Consider uploading reports for the commit 309052b to get more accurate results
```diff
@@ Coverage Diff @@
## main #1752 +/- ##
==========================================
- Coverage 46.70% 46.68% -0.01%
==========================================
Files 161 161
Lines 10022 10022
Branches 925 925
==========================================
- Hits 4680 4678 -2
- Misses 5022 5023 +1
- Partials 320 321 +1
```
[see 3 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1752/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on pull request #1752: [CELEBORN-826][DOC] Add storage document
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on PR #1752:
URL: https://github.com/apache/incubator-celeborn/pull/1752#issuecomment-1647425670
Thanks, merged to main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on pull request #1752: [CELEBORN-826][DOC] Add storage document
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on PR #1752:
URL: https://github.com/apache/incubator-celeborn/pull/1752#issuecomment-1647335120
cc @pan3793 @cfmcgrady @AngersZhuuuu @RexXiong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture closed pull request #1752: [CELEBORN-826][DOC] Add storage document
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture closed pull request #1752: [CELEBORN-826][DOC] Add storage document
URL: https://github.com/apache/incubator-celeborn/pull/1752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org