You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by hb...@apache.org on 2010/08/22 11:55:03 UTC
svn commit: r987856 - in /maven/archetype/trunk/archetype-plugin/src/main/java/org/apache/maven/archetype/ui: DefaultArchetypeCreationQueryer.java DefaultArchetypeGenerationQueryer.java

Author: hboutemy
Date: Sun Aug 22 09:55:03 2010
New Revision: 987856

URL: http://svn.apache.org/viewvc?rev=987856&view=rev
Log:
avoid String+= in loops

Modified:
    maven/archetype/trunk/archetype-plugin/src/main/java/org/apache/maven/archetype/ui/DefaultArchetypeCreationQueryer.java
    maven/archetype/trunk/archetype-plugin/src/main/java/org/apache/maven/archetype/ui/DefaultArchetypeGenerationQueryer.java

Modified: maven/archetype/trunk/archetype-plugin/src/main/java/org/apache/maven/archetype/ui/DefaultArchetypeCreationQueryer.java
URL: http://svn.apache.org/viewvc/maven/archetype/trunk/archetype-plugin/src/main/java/org/apache/maven/archetype/ui/DefaultArchetypeCreationQueryer.java?rev=987856&r1=987855&r2=987856&view=diff
==============================================================================
--- maven/archetype/trunk/archetype-plugin/src/main/java/org/apache/maven/archetype/ui/DefaultArchetypeCreationQueryer.java (original)
+++ maven/archetype/trunk/archetype-plugin/src/main/java/org/apache/maven/archetype/ui/DefaultArchetypeCreationQueryer.java Sun Aug 22 09:55:03 2010
@@ -87,20 +87,20 @@ public class DefaultArchetypeCreationQue
     public boolean confirmConfiguration( ArchetypeConfiguration archetypeConfiguration )
         throws PrompterException
     {
-        String query =
-            "Confirm archetype configuration:\n" + Constants.ARCHETYPE_GROUP_ID + "="
+        StringBuilder query =
+            new StringBuilder( "Confirm archetype configuration:\n" + Constants.ARCHETYPE_GROUP_ID + "="
                 + archetypeConfiguration.getGroupId() + "\n" + Constants.ARCHETYPE_ARTIFACT_ID + "="
                 + archetypeConfiguration.getArtifactId() + "\n" + Constants.ARCHETYPE_VERSION + "="
-                + archetypeConfiguration.getVersion() + "\n";
+                + archetypeConfiguration.getVersion() + "\n" );
 
         for ( Iterator propertiesIter = archetypeConfiguration.getProperties().keySet().iterator();
             propertiesIter.hasNext(); )
         {
             String property = (String) propertiesIter.next();
-            query += property + "=" + archetypeConfiguration.getProperty( property ) + "\n";
+            query.append( property + "=" + archetypeConfiguration.getProperty( property ) + "\n" );
         }
 
-        String answer = prompter.prompt( query, "Y" );
+        String answer = prompter.prompt( query.toString(), "Y" );
 
         return "Y".equalsIgnoreCase( answer );
     }

Modified: maven/archetype/trunk/archetype-plugin/src/main/java/org/apache/maven/archetype/ui/DefaultArchetypeGenerationQueryer.java
URL: http://svn.apache.org/viewvc/maven/archetype/trunk/archetype-plugin/src/main/java/org/apache/maven/archetype/ui/DefaultArchetypeGenerationQueryer.java?rev=987856&r1=987855&r2=987856&view=diff
==============================================================================
--- maven/archetype/trunk/archetype-plugin/src/main/java/org/apache/maven/archetype/ui/DefaultArchetypeGenerationQueryer.java (original)
+++ maven/archetype/trunk/archetype-plugin/src/main/java/org/apache/maven/archetype/ui/DefaultArchetypeGenerationQueryer.java Sun Aug 22 09:55:03 2010
@@ -34,14 +34,14 @@ public class DefaultArchetypeGenerationQ
     public boolean confirmConfiguration( ArchetypeConfiguration archetypeConfiguration )
         throws PrompterException
     {
-        String query = "Confirm properties configuration:\n";
+        StringBuilder query = new StringBuilder( "Confirm properties configuration:\n" );
 
         for ( String property : archetypeConfiguration.getRequiredProperties() )
         {
-            query += property + ": " + archetypeConfiguration.getProperty( property ) + "\n";
+            query.append( property + ": " + archetypeConfiguration.getProperty( property ) + "\n" );
         }
 
-        String answer = prompter.prompt( query, "Y" );
+        String answer = prompter.prompt( query.toString(), "Y" );
 
         return "Y".equalsIgnoreCase( answer );
     }