You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2021/10/25 19:01:00 UTC
[jira] [Commented] (SOLR-15628) SolrException.log doesn't pass
Throwable to Logger correctly
[ https://issues.apache.org/jira/browse/SOLR-15628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433933#comment-17433933 ]
ASF subversion and git services commented on SOLR-15628:
--------------------------------------------------------
Commit eac7e9efc054357d7219040b1e36a9dc202deea1 in lucene-solr's branch refs/heads/branch_8x from Chris M. Hostetter
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=eac7e9e ]
SOLR-15628: The SolrException.log() helper method has been fixed to correctly passes the Throwable to the Logger w/o stringification
(cherry picked from commit b60642c719f73f998d5130837b0fbaa1b91687a7)
> SolrException.log doesn't pass Throwable to Logger correctly
> ------------------------------------------------------------
>
> Key: SOLR-15628
> URL: https://issues.apache.org/jira/browse/SOLR-15628
> Project: Solr
> Issue Type: Bug
> Reporter: Chris M. Hostetter
> Assignee: Chris M. Hostetter
> Priority: Major
> Fix For: main (9.0)
>
> Attachments: SOLR-15628.patch
>
>
> Having recently started using JSON based logging, I noticed that in many code paths situations where an error involving a "Throwable" are logged isn't happening correctly (This is also noticeable using the default solr log4j2.xml configuration - but only subtly)
> The problem is that {{SolrException.log(...)}} has some very old (pre Solr 1.0, certainly pre SLF4j/Log4j) and hackish logic/code in it to support {{SolrException.ignorePatterns}} (which was designed for tests that wanted "quieter" output when they were intentionally triggering error situations. This logic "stringifies" the entire Throwable (including stack trace) to test against any {{ignorePatterns}} that exist (even if there are no ignore patterns) before handing the resulting string off to the {{loggger.error(...)}} call -- _as a log message string_ - w/o the normal "structure" context of the original Throwable instance.
> This causes the full exception stack trace to come through as the log "message" -- even in log appenders that have been configured to only log partial stack trace details, or log them in special fields (ie: JSON Logging)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org