[GitHub] [nifi] markap14 commented on a change in pull request #4537: NIFI-7817: Fix ParquetReader instantiation error

[GitBox <gi...@apache.org>]

markap14 commented on a change in pull request #4537:
URL: https://github.com/apache/nifi/pull/4537#discussion_r491063326



##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/service/StandardConfigurationContext.java
##########
@@ -78,7 +78,9 @@ public PropertyValue getProperty(final PropertyDescriptor property) {
         // We need to get the 'canonical representation' of the property descriptor from the component itself,
         // since the supplied PropertyDescriptor may not have the proper default value.
         final PropertyDescriptor resolvedDescriptor = component.getPropertyDescriptor(property.getName());
-        final String resolvedValue = (configuredValue == null) ? resolvedDescriptor.getDefaultValue() : configuredValue;

Review comment:
       I don't think this code should be changing at all. We should not use the default value of the given Property Descriptor, but rather use the default value of the one provided by the Controller Service. It appears that the Controller Service is not actually providing a Property Descriptor for this property, which means that it should return `null`. If the Controller Service wants to make use of that property, it needs to expose that property in its `getSupportedPropertyDescriptors` or `getSupportedDynamicPropertyDescriptor` method




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org