[GitHub] [superset] ktmud edited a comment on pull request #13211: fix(explore): Reset values in TextControl only when datasource changes

[GitBox <gi...@apache.org>]

ktmud edited a comment on pull request #13211:
URL: https://github.com/apache/superset/pull/13211#issuecomment-782418459


   Hi @junlincc @pkdotson @villebro @kgabryje  , going back to the original PR (#12782 ) that introduced this bug, I don't think `TextControl` should be included in the controls that reset values when users change datasource. Because most of the time, the input value in `TextControl` is not datasource specific---i.e. they are not related to columns and metrics. As discussed in #12782, the original input (axis labels, bounds, etc.) could be useful when plotting with a new datasource.
   
   I'm going to remove the reset logic in my [control refactoring PR](https://github.com/apache/superset/pull/13221) if you don't mind.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org