You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by majetideepak <gi...@git.apache.org> on 2016/07/06 21:04:18 UTC

[GitHub] orc pull request #46: ORC-80:C++ build breaks due to warnings with gcc-4.9

GitHub user majetideepak opened a pull request:

    https://github.com/apache/orc/pull/46

    ORC-80:C++ build breaks due to warnings with gcc-4.9

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/majetideepak/orc ORC-80

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/orc/pull/46.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #46
    
----
commit 281ef817e01d8d7cea1d0f5c7ede73fc08a2a2b4
Author: Deepak Majeti <de...@hpe.com>
Date:   2016-07-06T21:03:32Z

    ORC-80:C++ build breaks due to warnings with gcc-4.9

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] orc pull request #46: ORC-80:C++ build breaks due to warnings with gcc-4.9

Posted by majetideepak <gi...@git.apache.org>.
Github user majetideepak commented on a diff in the pull request:

    https://github.com/apache/orc/pull/46#discussion_r69811300
  
    --- Diff: tools/test/ToolTest.cc ---
    @@ -163,7 +163,7 @@ int runProgram(const std::vector<std::string>& command,
         if (result == -1) {
           std::cerr << "Error: " << strerror(errno) << "\n";
         } else if (WIFSIGNALED(status)) {
    -      std::cerr << "Fatal signal: " << WTERMSIG(signal) << "\n";
    +      std::cerr << "Fatal signal: " << WTERMSIG(status) << "\n";
    --- End diff --
    
    @xunzhang let me know if `status` is incorrect here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] orc pull request #46: ORC-80:C++ build breaks due to warnings with gcc-4.9

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/orc/pull/46


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---