[GitHub] [iceberg] kbendick commented on a diff in pull request #4877: API: Pass FileIO into Snapshot methods that read metadata - Backport

[GitBox <gi...@apache.org>]

kbendick commented on code in PR #4877:
URL: https://github.com/apache/iceberg/pull/4877#discussion_r883088734


##########
spark/v3.0/spark/src/main/java/org/apache/iceberg/spark/actions/BaseRewriteManifestsSparkAction.java:
##########
@@ -261,7 +261,7 @@ private List<ManifestFile> findMatchingManifests() {
       return ImmutableList.of();
     }
 
-    return currentSnapshot.dataManifests().stream()
+    return currentSnapshot.dataManifests(fileIO).stream()

Review Comment:
   For this usage, there's a class level `fileIO` that is wrapped to avoid Kryo serialization issues. So we use that instead of `table..io()`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org