You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/02/20 19:18:34 UTC
[Impala-ASF-CR] IMPALA-8223: remove {mem-pool,hash-table}.total-bytes
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12528
Change subject: IMPALA-8223: remove {mem-pool,hash-table}.total-bytes
......................................................................
IMPALA-8223: remove {mem-pool,hash-table}.total-bytes
These metrics have some issues (see the JIRA) and are not very relevant
in a world where most of the memory comes from the BufferPool
Change-Id: I61c8ca1ddf20676252eae958bc2d293e0ec67ecf
---
M be/src/exec/hash-table.cc
M be/src/exec/hdfs-orc-scanner.cc
M be/src/runtime/mem-pool.cc
M be/src/util/impalad-metrics.cc
M be/src/util/impalad-metrics.h
M common/thrift/metrics.json
M tests/verifiers/metric_verifier.py
7 files changed, 0 insertions(+), 58 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/28/12528/5
--
To view, visit http://gerrit.cloudera.org:8080/12528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I61c8ca1ddf20676252eae958bc2d293e0ec67ecf
Gerrit-Change-Number: 12528
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8223: remove {mem-pool,hash-table}.total-bytes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12528 )
Change subject: IMPALA-8223: remove {mem-pool,hash-table}.total-bytes
......................................................................
IMPALA-8223: remove {mem-pool,hash-table}.total-bytes
These metrics have some issues (see the JIRA) and are not very relevant
in a world where most of the memory comes from the BufferPool
Change-Id: I61c8ca1ddf20676252eae958bc2d293e0ec67ecf
Reviewed-on: http://gerrit.cloudera.org:8080/12528
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/hash-table.cc
M be/src/exec/hdfs-orc-scanner.cc
M be/src/runtime/mem-pool.cc
M be/src/util/impalad-metrics.cc
M be/src/util/impalad-metrics.h
M common/thrift/metrics.json
M tests/verifiers/metric_verifier.py
7 files changed, 0 insertions(+), 58 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I61c8ca1ddf20676252eae958bc2d293e0ec67ecf
Gerrit-Change-Number: 12528
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-8223: remove {mem-pool,hash-table}.total-bytes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12528 )
Change subject: IMPALA-8223: remove {mem-pool,hash-table}.total-bytes
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3843/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I61c8ca1ddf20676252eae958bc2d293e0ec67ecf
Gerrit-Change-Number: 12528
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 05:25:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8223: remove {mem-pool,hash-table}.total-bytes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12528 )
Change subject: IMPALA-8223: remove {mem-pool,hash-table}.total-bytes
......................................................................
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I61c8ca1ddf20676252eae958bc2d293e0ec67ecf
Gerrit-Change-Number: 12528
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 09:38:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8223: remove {mem-pool,hash-table}.total-bytes
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12528 )
Change subject: IMPALA-8223: remove {mem-pool,hash-table}.total-bytes
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I61c8ca1ddf20676252eae958bc2d293e0ec67ecf
Gerrit-Change-Number: 12528
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 03:43:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8223: remove {mem-pool,hash-table}.total-bytes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12528 )
Change subject: IMPALA-8223: remove {mem-pool,hash-table}.total-bytes
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2177/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I61c8ca1ddf20676252eae958bc2d293e0ec67ecf
Gerrit-Change-Number: 12528
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Feb 2019 19:51:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8223: remove {mem-pool,hash-table}.total-bytes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12528 )
Change subject: IMPALA-8223: remove {mem-pool,hash-table}.total-bytes
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I61c8ca1ddf20676252eae958bc2d293e0ec67ecf
Gerrit-Change-Number: 12528
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 05:25:56 +0000
Gerrit-HasComments: No