You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by kaspersorensen <gi...@git.apache.org> on 2015/12/07 13:22:52 UTC
[GitHub] metamodel pull request: Hardened the NumberComparator to have bett...
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/75
Hardened the NumberComparator to have better support for number types.
(Sorry for the code reformatting, but the old was clearly wrong - used
tabs instead of spaces)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kaspersorensen/metamodel feature/hardening-of-number-comparator
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel/pull/75.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #75
----
commit b411fa9c899f8181e4f41f260e2ac40a001cd785
Author: Kasper Sørensen <i....@gmail.com>
Date: 2015-12-07T12:22:30Z
Hardened the NumberComparator to have better support for number types.
(Sorry for the code reformatting, but the old was clearly wrong - used
tabs instead of spaces)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Hardened the NumberComparator to have bett...
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on the pull request:
https://github.com/apache/metamodel/pull/75#issuecomment-162518104
Okay, it probably doesn't matter. It doesn't seem to be used for (SQL) equals unless there's a need to parse it anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Hardened the NumberComparator to have bett...
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on the pull request:
https://github.com/apache/metamodel/pull/75#issuecomment-162516676
I realize we are for much more than SQL, but the null comparisons being equal worries me a bit, "NULL is never equal to anything" is a pretty important part of SQL (and maybe one of the few things all SQL vendors can agree on).
OTOH, NULL is never NOT equal to anything else, so this may still be wrong SQL-wise.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Hardened the NumberComparator to have bett...
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on the pull request:
https://github.com/apache/metamodel/pull/75#issuecomment-162521315
Yeah. That @losd guy started panicking, but I calmed him down :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Hardened the NumberComparator to have bett...
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on the pull request:
https://github.com/apache/metamodel/pull/75#issuecomment-162511561
Ugh, huge reformatting. But fair, most of the file was changed anyway, and it had the wrong indentation character before (and the secret 'add ?w=1 to URL' Github trick saved the comparison).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Hardened the NumberComparator to have bett...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/75
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Hardened the NumberComparator to have bett...
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/75#issuecomment-162520686
Glad that you sorted it out ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Hardened the NumberComparator to have bett...
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on the pull request:
https://github.com/apache/metamodel/pull/75#issuecomment-162518223
Let's go with the LGTM :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---