[I] [Task]: Visibility of ValueMetaBase Constructors (hop)

["fskorgen (via GitHub)" <gi...@apache.org>]

fskorgen opened a new issue, #6988:
URL: https://github.com/apache/hop/issues/6988

   ### What needs to happen?
   
   During migration of legacy PDI transformations to HOP, some code paths use the public constructor:
   
       public ValueMetaBase(String name, int type, int length, int precision)
   
   Using these public constructors can lead to issues in transformations that rely on inherited members in subclasses of ValueMetaBase.
   
   This makes it harder to ensure correct usage and can introduce subtle bugs.
   
   ### Recommendation
   
   Change the following constructors from public to protected:
   
       protected ValueMetaBase(String name)
       protected ValueMetaBase(String name, int type)
       protected ValueMetaBase(String name, int type, Comparator<Object> comparator)
       protected ValueMetaBase(String name, int type, int length, int precision)
       protected ValueMetaBase(String name, int type, int length, int precision, Comparator<Object> comparator)
   
   ### Expected Outcome
   * Encourage use of ValueMetaFactory.createValueMeta(...)
   * Prevent incorrect direct instantiation
   * Clarify intended usage patterns
   
   ### Additional Context
   
   The ValueMetaFactory should be the preferred way to create instances, as it ensures consistent initialization and better compatibility across transformations.
   
   ### Issue Priority
   
   Priority: 3
   
   ### Issue Component
   
   Component: API


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Task]: Visibility of ValueMetaBase Constructors (hop)

["mattcasters (via GitHub)" <gi...@apache.org>]

mattcasters closed issue #6988: [Task]: Visibility of ValueMetaBase Constructors
URL: https://github.com/apache/hop/issues/6988


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org