[GitHub] [ignite-3] alievmirza commented on a change in pull request #378: IGNITE-15538 Fixed NullPointerException during node start via cli.

[GitBox <gi...@apache.org>]

alievmirza commented on a change in pull request #378:
URL: https://github.com/apache/ignite-3/pull/378#discussion_r723044482



##########
File path: modules/cli/src/main/java/org/apache/ignite/cli/builtins/node/NodeManager.java
##########
@@ -111,8 +111,7 @@ public RunningNode start(String nodeName, Path logDir, Path pidsDir, Path srvCfg
             Process p = pb.start();
 
             try (var spinner = new Spinner(out, "Starting a new Ignite node")) {
-
-                if (!waitForStart("Apache Ignite started successfully!", logFile, NODE_START_TIMEOUT, spinner)) {
+                if (!waitForStart("Apache Ignite started successfully!", logFile, p, NODE_START_TIMEOUT, spinner)) {
                     p.destroyForcibly();
 
                     throw new IgniteCLIException("Node wasn't started during timeout period "

Review comment:
       I think it would be nice to add an additional message here about checking log files, what do you think? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org