You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2014/11/09 06:41:59 UTC

Review Request 27785: SQOOP-1696 Sqoop2: TestMapReduce.testOutputFormat is failing on Hadoop 1 profile

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27785/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-1696
    https://issues.apache.org/jira/browse/SQOOP-1696


Repository: sqoop-trunk


Description
-------

I've added logic that detects Hadoop 1 (copied from Sqoop 1) and code that conditionally runs the OutputCommitter on Hadoop 1.


Diffs
-----

  execution/mapreduce/src/test/java/org/apache/sqoop/job/JobUtils.java 7ce8011 

Diff: https://reviews.apache.org/r/27785/diff/


Testing
-------

Test in question now passes.


Thanks,

Jarek Cecho


Re: Review Request 27785: SQOOP-1696 Sqoop2: TestMapReduce.testOutputFormat is failing on Hadoop 1 profile

Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27785/#review60501
-----------------------------------------------------------

Ship it!


Ship It!

- Abraham Elmahrek


On Nov. 9, 2014, 5:41 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27785/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2014, 5:41 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1696
>     https://issues.apache.org/jira/browse/SQOOP-1696
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> I've added logic that detects Hadoop 1 (copied from Sqoop 1) and code that conditionally runs the OutputCommitter on Hadoop 1.
> 
> 
> Diffs
> -----
> 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/JobUtils.java 7ce8011 
> 
> Diff: https://reviews.apache.org/r/27785/diff/
> 
> 
> Testing
> -------
> 
> Test in question now passes.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>