You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/12/06 22:35:00 UTC
[jira] [Work logged] (GOBBLIN-983) Replace javafx stringformatter
with Java's String library
[ https://issues.apache.org/jira/browse/GOBBLIN-983?focusedWorklogId=355482&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-355482 ]
ASF GitHub Bot logged work on GOBBLIN-983:
------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Dec/19 22:34
Start Date: 06/Dec/19 22:34
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2829: [GOBBLIN-983] Use java string library for string format
URL: https://github.com/apache/incubator-gobblin/pull/2829#issuecomment-558776546
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2829?src=pr&el=h1) Report
> Merging [#2829](https://codecov.io/gh/apache/incubator-gobblin/pull/2829?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/2bbf42bbc47ce76597180066007164d385f64565?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2829?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2829 +/- ##
============================================
+ Coverage 45.65% 45.65% +<.01%
- Complexity 8984 8986 +2
============================================
Files 1903 1903
Lines 71331 71331
Branches 7873 7873
============================================
+ Hits 32566 32568 +2
- Misses 35764 35766 +2
+ Partials 3001 2997 -4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2829?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ro/JsonElementConversionWithAvroSchemaFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2829/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9hdnJvL0pzb25FbGVtZW50Q29udmVyc2lvbldpdGhBdnJvU2NoZW1hRmFjdG9yeS5qYXZh) | `68.62% <0%> (ø)` | `6 <0> (ø)` | :arrow_down: |
| [...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2829/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh) | `32.71% <0%> (-2.81%)` | `11% <0%> (-1%)` | |
| [...main/java/org/apache/gobblin/util/HadoopUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2829/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGFkb29wVXRpbHMuamF2YQ==) | `30.2% <0%> (-0.68%)` | `24% <0%> (-1%)` | |
| [.../apache/gobblin/runtime/api/JobExecutionState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2829/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvblN0YXRlLmphdmE=) | `80.37% <0%> (+0.93%)` | `24% <0%> (ø)` | :arrow_down: |
| [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2829/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==) | `65.27% <0%> (+1.85%)` | `28% <0%> (+1%)` | :arrow_up: |
| [...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2829/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=) | `92.85% <0%> (+7.14%)` | `4% <0%> (+1%)` | :arrow_up: |
| [...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2829/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh) | `60% <0%> (+20%)` | `3% <0%> (+1%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2829?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2829?src=pr&el=footer). Last update [2bbf42b...6f91b82](https://codecov.io/gh/apache/incubator-gobblin/pull/2829?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 355482)
Time Spent: 40m (was: 0.5h)
> Replace javafx stringformatter with Java's String library
> ---------------------------------------------------------
>
> Key: GOBBLIN-983
> URL: https://issues.apache.org/jira/browse/GOBBLIN-983
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: William Lo
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> There is one instance of `com.sun.javafx.binding.StringFormatter`. Using javafx libraries is not available in many versions of java that run on server. Since it's only used to format a string, proposal to use Java's String library instead
--
This message was sent by Atlassian Jira
(v8.3.4#803005)