You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Douglas Creager (JIRA)" <ji...@apache.org> on 2011/07/15 01:12:00 UTC

[jira] [Created] (AVRO-861) Remove dependency on C99 stdbool.h header

Remove dependency on C99 stdbool.h header
-----------------------------------------

                 Key: AVRO-861
                 URL: https://issues.apache.org/jira/browse/AVRO-861
             Project: Avro
          Issue Type: Bug
          Components: c
    Affects Versions: 1.6.0
            Reporter: Douglas Creager
            Assignee: Douglas Creager
            Priority: Minor


Buildbot raised on error on Solaris, saying that the stdbool.h header is only allowed in C99 code.  Bruce pointed out that it would be safer and more portable to not rely on any C99 standards if we don't have to.  In this case, it's easy enough to replace bool with int, true with 1, and false with 0.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (AVRO-861) Remove dependency on C99 stdbool.h header

Posted by "Douglas Creager (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Douglas Creager updated AVRO-861:
---------------------------------

    Attachment: 0001-AVRO-861.-C-Remove-dependency-on-stdbool.h.patch

Here's a patch that removes all traces of stdbool.h

> Remove dependency on C99 stdbool.h header
> -----------------------------------------
>
>                 Key: AVRO-861
>                 URL: https://issues.apache.org/jira/browse/AVRO-861
>             Project: Avro
>          Issue Type: Bug
>          Components: c
>    Affects Versions: 1.6.0
>            Reporter: Douglas Creager
>            Assignee: Douglas Creager
>            Priority: Minor
>         Attachments: 0001-AVRO-861.-C-Remove-dependency-on-stdbool.h.patch
>
>
> Buildbot raised on error on Solaris, saying that the stdbool.h header is only allowed in C99 code.  Bruce pointed out that it would be safer and more portable to not rely on any C99 standards if we don't have to.  In this case, it's easy enough to replace bool with int, true with 1, and false with 0.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (AVRO-861) Remove dependency on C99 stdbool.h header

Posted by "Douglas Creager (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Douglas Creager resolved AVRO-861.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.6.0

Committed to SVN.  The Solaris buildbot is succeeding again.

> Remove dependency on C99 stdbool.h header
> -----------------------------------------
>
>                 Key: AVRO-861
>                 URL: https://issues.apache.org/jira/browse/AVRO-861
>             Project: Avro
>          Issue Type: Bug
>          Components: c
>    Affects Versions: 1.6.0
>            Reporter: Douglas Creager
>            Assignee: Douglas Creager
>            Priority: Minor
>             Fix For: 1.6.0
>
>         Attachments: 0001-AVRO-861.-C-Remove-dependency-on-stdbool.h.patch
>
>
> Buildbot raised on error on Solaris, saying that the stdbool.h header is only allowed in C99 code.  Bruce pointed out that it would be safer and more portable to not rely on any C99 standards if we don't have to.  In this case, it's easy enough to replace bool with int, true with 1, and false with 0.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira