You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/01/12 14:39:54 UTC
[GitHub] [skywalking] kezhenxu94 opened a new pull request #4221: Add alarm
metrics OP >= and <=, and refactor the operator logics
kezhenxu94 opened a new pull request #4221: Add alarm metrics OP >= and <=, and refactor the operator logics
URL: https://github.com/apache/skywalking/pull/4221
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [x] New feature provided
- [ ] Improve performance
- [x] Refactor
This PR follows up the #4214 to refactor the operators and add another two operators `>=` and `<=`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4221: Add alarm
metrics OP >= and <=, and refactor the operator logics
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4221: Add alarm metrics OP >= and <=, and refactor the operator logics
URL: https://github.com/apache/skywalking/pull/4221#issuecomment-573425215
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4221?src=pr&el=h1) Report
> Merging [#4221](https://codecov.io/gh/apache/skywalking/pull/4221?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/260ea954376cc4ac1bf142f3108e1aa3303f2ae8?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/skywalking/pull/4221?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4221 +/- ##
==========================================
+ Coverage 26.34% 26.34% +<.01%
==========================================
Files 1179 1179
Lines 25805 25805
Branches 3749 3749
==========================================
+ Hits 6798 6799 +1
+ Misses 18403 18402 -1
Partials 604 604
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4221?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...er/sharing/server/ReceiverGRPCHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/4221/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvUmVjZWl2ZXJHUlBDSGFuZGxlclJlZ2lzdGVyLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...ap/server/core/server/GRPCHandlerRegisterImpl.java](https://codecov.io/gh/apache/skywalking/pull/4221/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL0dSUENIYW5kbGVyUmVnaXN0ZXJJbXBsLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4221/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| [...er/sharing/server/SharingServerModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4221/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvU2hhcmluZ1NlcnZlck1vZHVsZVByb3ZpZGVyLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/4221/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `67.94% <0%> (+1.28%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4221?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4221?src=pr&el=footer). Last update [260ea95...dc1584d](https://codecov.io/gh/apache/skywalking/pull/4221?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4221: Add alarm metrics
OP >= and <=, and refactor the operator logics
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4221: Add alarm metrics OP >= and <=, and refactor the operator logics
URL: https://github.com/apache/skywalking/pull/4221#issuecomment-573425215
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4221?src=pr&el=h1) Report
> Merging [#4221](https://codecov.io/gh/apache/skywalking/pull/4221?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9149de2a6e686ff5442ec5bfd2d00ea4912fb911?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `47.61%`.
[](https://codecov.io/gh/apache/skywalking/pull/4221?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4221 +/- ##
==========================================
+ Coverage 26.44% 26.46% +0.01%
==========================================
Files 1179 1178 -1
Lines 25836 25782 -54
Branches 3760 3746 -14
==========================================
- Hits 6832 6822 -10
+ Misses 18399 18359 -40
+ Partials 605 601 -4
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4221?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/4221/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `74.83% <44.44%> (+8.92%)` | :arrow_up: |
| [.../skywalking/oap/server/core/alarm/provider/OP.java](https://codecov.io/gh/apache/skywalking/pull/4221/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9PUC5qYXZh) | `50% <50%> (-7.15%)` | :arrow_down: |
| [...m/agent/core/remote/TraceSegmentServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/4221/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RyYWNlU2VnbWVudFNlcnZpY2VDbGllbnQuamF2YQ==) | `82.35% <0%> (+1.47%)` | :arrow_up: |
| [.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4221/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=) | `31.46% <0%> (+3.37%)` | :arrow_up: |
| [...pm/agent/core/profile/ProfileTaskQueryService.java](https://codecov.io/gh/apache/skywalking/pull/4221/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1F1ZXJ5U2VydmljZS5qYXZh) | `51.28% <0%> (+7.69%)` | :arrow_up: |
| [...alking/apm/agent/core/remote/AgentIDDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4221/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0FnZW50SUREZWNvcmF0b3IuamF2YQ==) | `85.71% <0%> (+17.85%)` | :arrow_up: |
| [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4221/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `77.04% <0%> (+18.03%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4221?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4221?src=pr&el=footer). Last update [9149de2...260ea95](https://codecov.io/gh/apache/skywalking/pull/4221?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4221: Add alarm
metrics OP >= and <=, and refactor the operator logics
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4221: Add alarm metrics OP >= and <=, and refactor the operator logics
URL: https://github.com/apache/skywalking/pull/4221#issuecomment-573425215
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4221?src=pr&el=h1) Report
> Merging [#4221](https://codecov.io/gh/apache/skywalking/pull/4221?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/260ea954376cc4ac1bf142f3108e1aa3303f2ae8?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4221?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4221 +/- ##
=======================================
Coverage 26.34% 26.34%
=======================================
Files 1179 1179
Lines 25805 25805
Branches 3749 3749
=======================================
Hits 6798 6798
Misses 18403 18403
Partials 604 604
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4221?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4221?src=pr&el=footer). Last update [260ea95...dc1584d](https://codecov.io/gh/apache/skywalking/pull/4221?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 merged pull request #4221: Add alarm
metrics OP >= and <=, and refactor the operator logics
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #4221: Add alarm metrics OP >= and <=, and refactor the operator logics
URL: https://github.com/apache/skywalking/pull/4221
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services