[GitHub] [incubator-nuttx] btashton commented on a change in pull request #1705: nRF52: refactor system timer handling; support tickless and nontickless using RTC/systick

[GitBox <gi...@apache.org>]

btashton commented on a change in pull request #1705:
URL: https://github.com/apache/incubator-nuttx/pull/1705#discussion_r483228442



##########
File path: tools/checkpatch.sh
##########
@@ -84,14 +84,14 @@ check_patch() {
     fail=1
   else
     git apply $1
-    diffs=`cat $1`
+    diffs=``
     check_ranges <<< "$diffs"
     git apply -R $1
   fi
 }
 
 check_commit() {
-  diffs=`git show $1`
+  diffs=`git show --no-renames $1`

Review comment:
       This can just be `git diff $1` which will resolve the issue with renames.  `show` was the wrong command to use here.

##########
File path: tools/checkpatch.sh
##########
@@ -84,14 +84,14 @@ check_patch() {
     fail=1
   else
     git apply $1
-    diffs=`cat $1`
+    diffs=``

Review comment:
       This should not have changed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org