[jira] Resolved: (SHINDIG-271) Unecessary urldecode prevent proxyed data to be read

["Chris Chabot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SHINDIG-271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Chabot resolved SHINDIG-271.
----------------------------------

    Resolution: Fixed
      Assignee: Chris Chabot

Thanks for the report!

Fixed and commited:
http://svn.apache.org/viewvc/incubator/shindig/trunk/php/src/gadgets/http/ProxyServlet.php?rev=656901&r1=656900&r2=656901&view=diff



> Unecessary urldecode prevent proxyed data to be read
> ----------------------------------------------------
>
>                 Key: SHINDIG-271
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-271
>             Project: Shindig
>          Issue Type: Bug
>          Components: Gadget Rendering Server (PHP)
>         Environment: PHP 5.2.5 / Linux Ubuntu 7.10
>            Reporter: fhodierne
>            Assignee: Chris Chabot
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> In ProxyServlet.php, the $url = urldecode($url) is unnecessary and prevent data to be read in js after.
> The problem can reproduced with url of kind:
> http://example.com/feed?url=http%3A%2F%2Ffeeds.feedburner.com%2FDilbertDailyStrip
> Which produce:
> throw 1; < don't be evil' >{"http:\/\/example.com\/feed?url=http:\/\/feeds.feedburner.com\/DilbertDailyStrip":{"body":
> Instead of:
> throw 1; < don't be evil' >{"http:\/\/example.com\/feed?url=http%3A%2F%2Ffeeds.feedburner.com%2FDilbertDailyStrip":{"body":
> As a result, in io.js after, data[url] do not exists because key is wrong.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.